Bug 224270

Summary: [GPU Process] Simplify DisplayList::Iterator part 6: Migrate ItemBufferWritingClient from ItemHandle to a const Variant&
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 223560, 224314    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
wenson_hsieh: review+
Patch for committing
none
Patch for committing none

Description Myles C. Maxfield 2021-04-07 00:15:16 PDT 
[GPU Process] Simplify DisplayList::Iterator part 6: Migrate ItemBufferWritingClient from ItemHandle to a const Variant&
Comment 1 Myles C. Maxfield 2021-04-07 00:23:41 PDT 
Created attachment 425359 [details]
Patch
Comment 2 Myles C. Maxfield 2021-04-07 00:44:51 PDT 
Created attachment 425362 [details]
Patch
Comment 3 Myles C. Maxfield 2021-04-07 18:41:20 PDT 
Comment on attachment 425362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425362&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp:607
> +inline bool safeCopyHelper(const T& source, ItemHandle destination)

We can do
using T = typename WTF::RemoveCVAndReference<decltype(a)>::type;
instead of needing a helper.

> Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:324
> +    static RefPtr<WebCore::SharedBuffer> encodeItemOutOfLineHelper(const T& item)

Ditto.
Comment 4 Myles C. Maxfield 2021-04-07 19:32:09 PDT 
Created attachment 425471 [details]
Patch
Comment 5 Wenson Hsieh 2021-04-12 15:27:22 PDT 
Comment on attachment 425471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425471&action=review

> Source/WebKit/WebKit.xcodeproj/xcshareddata/xcschemes/WebKit.xcscheme:34
> +      buildConfiguration = "Debug"

This change doesn't seem intentional.
Comment 6 Radar WebKit Bug Importer 2021-04-14 00:16:15 PDT 
<rdar://problem/76631891>
Comment 7 Myles C. Maxfield 2021-05-09 00:55:59 PDT 
Created attachment 428114 [details]
Patch for committing
Comment 8 Myles C. Maxfield 2021-05-09 01:56:34 PDT 
Created attachment 428117 [details]
Patch for committing
Comment 9 EWS 2021-05-09 02:52:55 PDT 
Committed r277244 (237513@main): <https://commits.webkit.org/237513@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428117 [details].