Bug 224270

Summary: [GPU Process] Simplify DisplayList::Iterator part 6: Migrate ItemBufferWritingClient from ItemHandle to a const Variant&
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 223560, 224314    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
wenson_hsieh: review+
Patch for committing
none
Patch for committing none

Myles C. Maxfield
Reported 2021-04-07 00:15:16 PDT
[GPU Process] Simplify DisplayList::Iterator part 6: Migrate ItemBufferWritingClient from ItemHandle to a const Variant&
Attachments
Patch (25.60 KB, patch)
2021-04-07 00:23 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (25.85 KB, patch)
2021-04-07 00:44 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (26.41 KB, patch)
2021-04-07 19:32 PDT, Myles C. Maxfield 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch for committing (25.73 KB, patch)
2021-05-09 00:55 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (35.55 KB, patch)
2021-05-09 01:56 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-04-07 00:23:41 PDT
Created attachment 425359 [details] Patch
Myles C. Maxfield
Comment 2 2021-04-07 00:44:51 PDT
Created attachment 425362 [details] Patch
Myles C. Maxfield
Comment 3 2021-04-07 18:41:20 PDT
Comment on attachment 425362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425362&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp:607 > +inline bool safeCopyHelper(const T& source, ItemHandle destination) We can do using T = typename WTF::RemoveCVAndReference<decltype(a)>::type; instead of needing a helper. > Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:324 > + static RefPtr<WebCore::SharedBuffer> encodeItemOutOfLineHelper(const T& item) Ditto.
Myles C. Maxfield
Comment 4 2021-04-07 19:32:09 PDT
Created attachment 425471 [details] Patch
Wenson Hsieh
Comment 5 2021-04-12 15:27:22 PDT
Comment on attachment 425471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425471&action=review > Source/WebKit/WebKit.xcodeproj/xcshareddata/xcschemes/WebKit.xcscheme:34 > + buildConfiguration = "Debug" This change doesn't seem intentional.
Radar WebKit Bug Importer
Comment 6 2021-04-14 00:16:15 PDT
<rdar://problem/76631891>
Myles C. Maxfield
Comment 7 2021-05-09 00:55:59 PDT
Created attachment 428114 [details] Patch for committing
Myles C. Maxfield
Comment 8 2021-05-09 01:56:34 PDT
Created attachment 428117 [details] Patch for committing
EWS
Comment 9 2021-05-09 02:52:55 PDT
Committed r277244 (237513@main): <https://commits.webkit.org/237513@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428117 [details].
Note You need to log in before you can comment on or make changes to this bug.