Summary: | Wasted vector capacity under CSSFontFace::setUnicodeRange() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, macpherson, menard, mmaxfield, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2021-04-06 21:10:35 PDT
Created attachment 425352 [details]
Patch
Comment on attachment 425352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425352&action=review r=me > Source/WebCore/css/CSSFontFace.cpp:274 > auto& list = downcast<CSSValueList>(unicodeRange); What about using `map` instead? ``` auto ranges = WTF::map(downcast<CSSValueList>(unicodeRange), [] (auto& rangeValue) -> UnicodeRange { return { range.from(), range.to() }; }); ``` (In reply to Devin Rousso from comment #2) > Comment on attachment 425352 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=425352&action=review > > r=me > > > Source/WebCore/css/CSSFontFace.cpp:274 > > auto& list = downcast<CSSValueList>(unicodeRange); > > What about using `map` instead? > ``` > auto ranges = WTF::map(downcast<CSSValueList>(unicodeRange), [] (auto& > rangeValue) -> UnicodeRange { > return { range.from(), range.to() }; > }); > ``` CSSValueList doesn't quite allow map() to work. |