Summary: | [ macOS wk2 ] webrtc/libwebrtc/release-while-creating-offer.html is a flakey text failure | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robert Jenner <jenner> | ||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Robert Jenner
2021-04-06 18:04:00 PDT
Looks like the test has been flakey flailing close to when it started running on BigSur, with the first failure at r272143. I was able to reproduce the failure at BigSur Debug ToT using the following test: run-webkit-tests webrtc/libwebrtc/release-while-creating-offer.html --debug --iterations 1000 -f Updated test expectations to Pass Failure here, while test is under review: https://trac.webkit.org/changeset/275582/webkit Created attachment 425490 [details]
Patch
Created attachment 425723 [details]
Patch
Comment on attachment 425723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425723&action=review > Source/WTF/wtf/PlatformHave.h:-951 > - > -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000 && __MAC_OS_X_VERSION_MAX_ALLOWED >= 110300) \ > - || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 140500) \ > - || (PLATFORM(APPLETV) && __TV_OS_VERSION_MAX_ALLOWED >= 140500) \ > - || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED >= 70400) > -#define HAVE_VM_FLAGS_PERMANENT 1 > -#endif > - > -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000) \ > - || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) \ > - || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 80000) \ > - || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 150000) > -#define HAVE_CFNETWORK_NSURLSESSION_ATTRIBUTED_BUNDLE_IDENTIFIER 1 > -#endif I don't think you meant to include this Created attachment 425738 [details]
Patch for landing
> I don't think you meant to include this
Right, this is fixed in patch for landing!
Committed r275822 (236392@main): <https://commits.webkit.org/236392@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425738 [details]. |