Summary: | [WebXR] Introduce XRDeviceIdentifier and XRDeviceInfo to be used to communicate device info | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||||||||
Component: | New Bugs | Assignee: | Ada Chan <adachan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dino, sam, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Ada Chan
2021-04-06 10:06:17 PDT
Created attachment 425298 [details]
Patch
Comment on attachment 425298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425298&action=review > Source/WebKit/Shared/Cocoa/XRDeviceInfo.mm:41 > + encoder << static_cast<uint64_t>(features.size()); > + for (auto feature : features) > + encoder << feature; Odd, WebKit2's ArgumentCoders.h totally has a VectorArgumentCoder. Do you need this custom implementation? (In reply to Tim Horton from comment #2) > Comment on attachment 425298 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=425298&action=review > > > Source/WebKit/Shared/Cocoa/XRDeviceInfo.mm:41 > > + encoder << static_cast<uint64_t>(features.size()); > > + for (auto feature : features) > > + encoder << feature; > > Odd, WebKit2's ArgumentCoders.h totally has a VectorArgumentCoder. Do you > need this custom implementation? Ah, I did not realize that. I'll update the patch. Created attachment 425306 [details]
Patch
Tools/Scripts/svn-apply failed to apply attachment 425306 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Tools/Scripts/svn-apply failed to apply attachment 425306 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 425443 [details]
Patch
Committed r275640: <https://commits.webkit.org/r275640> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425443 [details]. Reopening to attach new patch. Created attachment 425520 [details]
Unreviewed build fix
(In reply to Wenson Hsieh from comment #11) > Created attachment 425520 [details] > Unreviewed build fix Thanks Wenson! Committed r275663 (236299@main): <https://commits.webkit.org/236299@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425520 [details]. |