Bug 224231 – Compiler warnings that need to be fixed

• Component: Tools / Tests
• Status: NEW

[Eleni Maria Stea]

--- Description ---

There are some compiler warnings that need to be fixed:

/WebKit/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
 WTFLogAlways("SQLiteIDBBackingStore::databasesSizeForDirectory filePath='%s', database='%s', size=%" PRIu64, file.utf8().data(), databaseName.utf8().data(), fileSize); 
last argument should be long long int.


WebKit/Source/WebCore/inspector/InspectorOverlay.cpp:
FloatLine lineBetweenColumnBottoms = { columnStartLine.end(), previousColumnEndLine.end() };
is not used.

Functions:
WebCore::FloatSize WebCore::expectedSizeForLayoutLabel(WTF::String, WebCore::InspectorOverlay::LabelArrowDirection, float) in /Source/WebCore/inspector/InspectorOverlay.cpp

and

WebCore::Color WebCore::CSSPropertyParserHelpers::mixColorComponents(WebCore::CSSPropertyParserHelpers::ColorMixColorSpace, const WebCore::CSSPropertyParserHelpers::ColorMixComponent&, const WebCore::CSSPropertyParserHelpers::ColorMixComponent&) in Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

don't have a return type.

[Eleni Maria Stea]

Created attachment 425260 [details]
Proposed patch for 224231

proposed patch, fixes compiler warnings

[Eleni Maria Stea]

broke the Apple build, working on v2

[Joseph Pecoraro]

Comment on attachment 425260 [details]
Proposed patch for 224231

View in context: https://bugs.webkit.org/attachment.cgi?id=425260&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1278
> +                WTFLogAlways("SQLiteIDBBackingStore::databasesSizeForDirectory filePath='%s', database='%s', size=%l" PRIu64, file.utf8().data(), databaseName.utf8().data(), fileSize);

Here the `PRIu64` is the format string value. It is like `%ull`. Perhaps an include is missing for your particular port?

[Radar WebKit Bug Importer]

<rdar://problem/76584339>

[Eleni Maria Stea]

Created attachment 427137 [details]
Patch

[Eleni Maria Stea]

(In reply to Joseph Pecoraro from comment #3)
> Comment on attachment 425260 [details]
> Proposed patch for 224231
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425260&action=review
> 
> > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1278
> > +                WTFLogAlways("SQLiteIDBBackingStore::databasesSizeForDirectory filePath='%s', database='%s', size=%l" PRIu64, file.utf8().data(), databaseName.utf8().data(), fileSize);
> 
> Here the `PRIu64` is the format string value. It is like `%ull`. Perhaps an
> include is missing for your particular port?

You must be right, I've changed my patch to fix the other two warnings, and I'm going to investigate this further. Thank you!