| Summary: | Remove RepaintLayoutRectsMap | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2021-04-05 17:18:29 PDT
Created attachment 425226 [details]
Patch
Comment on attachment 425226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425226&action=review great change. > Source/WebCore/rendering/ComplexLineLayout.cpp:1328 > + if (!layoutContext().needsFullRepaint() && m_flow.hasSelfPaintingLayer() && m_flow.layerRepaintRects()) { isn't m_flow.hasSelfPaintingLayer() redundant here (though maybe it provides some information about the type of content (backed by a layer) we are dealing here with). > Source/WebCore/rendering/RenderLayer.h:224 > + return WTF::nullopt; return { }; ? |