Bug 224203

Summary:

[CMake] Add WebKit::gtest target

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

CMake

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, ews-watchlist, gyuyoung.kim, Hironori.Fujii, mcatanzaro, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none

Description Don Olmstead 2021-04-05 13:53:41 PDT

Make an INTERFACE target out of gtest that propagates includes and other information. Remove the hacky parts around setting definitions as well.

Comment 1 Don Olmstead 2021-04-06 14:41:58 PDT Comment hidden (obsolete)

Created attachment 425327 [details]
Patch

Comment 2 Don Olmstead 2021-04-06 20:38:08 PDT

Created attachment 425346 [details]
Patch

Comment 3 Adrian Perez 2021-04-07 00:28:24 PDT

Comment on attachment 425346 [details]
Patch

Nice one!

View in context: https://bugs.webkit.org/attachment.cgi?id=425346&action=review

> Tools/ChangeLog:12
> +        capabilities.

I wonder if this might have come to be like it was because of the
confusion between Google's thing being called “gtest” and GLib's
thing *also* being called “gtest”… 🤷️

Comment 4 EWS 2021-04-07 05:09:42 PDT

Committed r275602: <https://commits.webkit.org/r275602>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425346 [details].