RESOLVED FIXED Bug 224203
[CMake] Add WebKit::gtest target 
https://bugs.webkit.org/show_bug.cgi?id=224203
Summary [CMake] Add WebKit::gtest target
Don Olmstead
Reported 2021-04-05 13:53:41 PDT
Make an INTERFACE target out of gtest that propagates includes and other information. Remove the hacky parts around setting definitions as well.
Attachments
Patch (8.22 KB, patch)
2021-04-06 14:41 PDT, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (9.39 KB, patch)
2021-04-06 20:38 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-04-06 14:41:58 PDT
Comment hidden (obsolete)
Don Olmstead
Comment 2 2021-04-06 20:38:08 PDT
Created attachment 425346 [details] Patch
Adrian Perez
Comment 3 2021-04-07 00:28:24 PDT
Comment on attachment 425346 [details] Patch Nice one! View in context: https://bugs.webkit.org/attachment.cgi?id=425346&action=review > Tools/ChangeLog:12 > + capabilities. I wonder if this might have come to be like it was because of the confusion between Google's thing being called “gtest” and GLib's thing *also* being called “gtest”… 🤷️
EWS
Comment 4 2021-04-07 05:09:42 PDT
Committed r275602: <https://commits.webkit.org/r275602> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425346 [details].
Note You need to log in before you can comment on or make changes to this bug.