Bug 224203 - [CMake] Add WebKit::gtest target
Summary: [CMake] Add WebKit::gtest target
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
Depends on:
Reported: 2021-04-05 13:53 PDT by Don Olmstead
Modified: 2021-04-07 05:09 PDT (History)
8 users (show)

See Also:

Patch (8.22 KB, patch)
2021-04-06 14:41 PDT, Don Olmstead
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (9.39 KB, patch)
2021-04-06 20:38 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-04-05 13:53:41 PDT
Make an INTERFACE target out of gtest that propagates includes and other information. Remove the hacky parts around setting definitions as well.
Comment 1 Don Olmstead 2021-04-06 14:41:58 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2021-04-06 20:38:08 PDT
Created attachment 425346 [details]
Comment 3 Adrian Perez 2021-04-07 00:28:24 PDT
Comment on attachment 425346 [details]

Nice one!

View in context: https://bugs.webkit.org/attachment.cgi?id=425346&action=review

> Tools/ChangeLog:12
> +        capabilities.

I wonder if this might have come to be like it was because of the
confusion between Google's thing being called “gtest” and GLib's
thing *also* being called “gtest”… 🤷️
Comment 4 EWS 2021-04-07 05:09:42 PDT
Committed r275602: <https://commits.webkit.org/r275602>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425346 [details].