Bug 224202

Summary: Replace the Optional metadata of ImageSource by a single OptionSet and the underlying metadata
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Said Abou-Hallawa
Reported 2021-04-05 13:51:08 PDT
Encapsulating the metadata in a Optionals adds extra memory cost.
Attachments
Patch (19.76 KB, patch)
2021-04-05 15:20 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (19.76 KB, patch)
2021-04-05 15:42 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (19.76 KB, patch)
2021-04-05 15:58 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (20.28 KB, patch)
2021-04-06 13:40 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2021-04-05 15:20:28 PDT
Created attachment 425213 [details] Patch
Tim Horton
Comment 2 2021-04-05 15:35:36 PDT
cahced!
Simon Fraser (smfr)
Comment 3 2021-04-05 15:37:27 PDT
Comment on attachment 425213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425213&action=review > Source/WebCore/platform/graphics/ImageSource.h:226 > + OptionSet<MetadataType> m_cahcedMetadata; "cahced"
Said Abou-Hallawa
Comment 4 2021-04-05 15:42:33 PDT
Created attachment 425216 [details] Patch
Said Abou-Hallawa
Comment 5 2021-04-05 15:58:44 PDT
Created attachment 425219 [details] Patch
Said Abou-Hallawa
Comment 6 2021-04-06 13:40:56 PDT
Created attachment 425320 [details] Patch
EWS
Comment 7 2021-04-06 16:36:32 PDT
Committed r275570: <https://commits.webkit.org/r275570> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425320 [details].
Radar WebKit Bug Importer
Comment 8 2021-04-06 16:37:17 PDT
<rdar://problem/76290352>
Note You need to log in before you can comment on or make changes to this bug.