Bug 224202

Summary: Replace the Optional metadata of ImageSource by a single OptionSet and the underlying metadata
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Said Abou-Hallawa 2021-04-05 13:51:08 PDT 
Encapsulating the metadata in a Optionals adds extra memory cost.
Comment 1 Said Abou-Hallawa 2021-04-05 15:20:28 PDT 
Created attachment 425213 [details]
Patch
Comment 2 Tim Horton 2021-04-05 15:35:36 PDT 
cahced!
Comment 3 Simon Fraser (smfr) 2021-04-05 15:37:27 PDT 
Comment on attachment 425213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425213&action=review

> Source/WebCore/platform/graphics/ImageSource.h:226
> +    OptionSet<MetadataType> m_cahcedMetadata;

"cahced"
Comment 4 Said Abou-Hallawa 2021-04-05 15:42:33 PDT 
Created attachment 425216 [details]
Patch
Comment 5 Said Abou-Hallawa 2021-04-05 15:58:44 PDT 
Created attachment 425219 [details]
Patch
Comment 6 Said Abou-Hallawa 2021-04-06 13:40:56 PDT 
Created attachment 425320 [details]
Patch
Comment 7 EWS 2021-04-06 16:36:32 PDT 
Committed r275570: <https://commits.webkit.org/r275570>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425320 [details].
Comment 8 Radar WebKit Bug Importer 2021-04-06 16:37:17 PDT 
<rdar://problem/76290352>