Bug 224200

Summary:

Web Inspector: Grid overlay line numbers should not include implicit tracks in negative line number calculations.

Product:

WebKit

Reporter:

Patrick Angle <pangle>

Component:

Web Inspector

Assignee:

Patrick Angle <pangle>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, pangle, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

224199

Bug Blocks:

Attachments:

Description	Flags
Patch v1.0	ews-feeder: commit-queue-

Description Patrick Angle 2021-04-05 13:12:36 PDT

The negative line numbers should only be counting from the last explicit track in each direction. Currently they are being shown as counting from the last track, including implicit tracks.

Comment 1 Radar WebKit Bug Importer 2021-04-06 10:20:18 PDT

<rdar://problem/76272817>

Comment 2 Patrick Angle 2021-04-06 13:48:39 PDT

Created attachment 425321 [details]
Patch v1.0

Comment 3 BJ Burg 2021-04-06 13:52:56 PDT

Comment on attachment 425321 [details]
Patch v1.0

r=me

Comment 4 EWS 2021-04-06 15:09:15 PDT

Committed r275558: <https://commits.webkit.org/r275558>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425321 [details].