Bug 224195

Summary: [PlayStation] Change mediaControlsLocalizedStrings to use unicode escapes
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: WebCore Misc.Assignee: Stephan Szabo <stephan.szabo>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, eric.carlson, ews-watchlist, glenn, jer.noble, joepeck, philipj, ross.kirsling, sergio, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Stephan Szabo
Reported 2021-04-05 12:16:36 PDT
With the change to use --fail-if-non-ascii on building the arrays for the user agent scripts because we do not want to load UTF-8 string into the heap, we started breaking on mediaControlsLocalizedStrings as it was using smart quotes. Switch to using the unicode escapes in the file so that the content as per slack discussion with Yusuke.
Attachments
Patch (1.32 KB, patch)
2021-04-05 12:19 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2021-04-05 12:19:51 PDT
Created attachment 425185 [details] Patch
Yusuke Suzuki
Comment 2 2021-04-05 16:04:36 PDT
Comment on attachment 425185 [details] Patch r=me
EWS
Comment 3 2021-04-06 04:25:39 PDT
Committed r275504: <https://commits.webkit.org/r275504> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425185 [details].
Radar WebKit Bug Importer
Comment 4 2021-04-06 04:26:29 PDT
<rdar://problem/76261746>
Note You need to log in before you can comment on or make changes to this bug.