Bug 224195 - [PlayStation] Change mediaControlsLocalizedStrings to use unicode escapes
Summary: [PlayStation] Change mediaControlsLocalizedStrings to use unicode escapes
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
Keywords: InRadar
Depends on:
Reported: 2021-04-05 12:16 PDT by Stephan Szabo
Modified: 2021-04-06 04:26 PDT (History)
11 users (show)

See Also:

Patch (1.32 KB, patch)
2021-04-05 12:19 PDT, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2021-04-05 12:16:36 PDT
With the change to use --fail-if-non-ascii on building the arrays for the user agent scripts because we do not want to load UTF-8 string into the heap, we started breaking on mediaControlsLocalizedStrings as it was using smart quotes. Switch to using the unicode escapes in the file so that the content as per slack discussion with Yusuke.
Comment 1 Stephan Szabo 2021-04-05 12:19:51 PDT
Created attachment 425185 [details]
Comment 2 Yusuke Suzuki 2021-04-05 16:04:36 PDT
Comment on attachment 425185 [details]

Comment 3 EWS 2021-04-06 04:25:39 PDT
Committed r275504: <https://commits.webkit.org/r275504>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425185 [details].
Comment 4 Radar WebKit Bug Importer 2021-04-06 04:26:29 PDT