| Summary: | [iOS] Prevent background blur when presenting date/time pickers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||||
| Component: | Forms | Assignee: | Aditya Keerthi <akeerthi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, cdumez, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | iPhone / iPad | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Aditya Keerthi
2021-04-05 09:38:05 PDT
Created attachment 425159 [details]
Patch
Thanks for the review! Will commit once the tree is open. Comment on attachment 425159 [details] Patch From https://ews-build.webkit.org/#/builders/53/builds/11856: WKDateTimeInputControl.mm:162:11: error: property 'preferredBackgroundEffects' not found on object of type '_UIContextMenuStyle *' Comment on attachment 425159 [details]
Patch
Restoring the r+ (and adding cq- instead).
The build fix here is straightforward (we probably just need to update UIKitSPI.h)
Created attachment 425184 [details]
Patch for landing
I did the r- so that rest of EWS bots do not process that patch (since they have backlog of patches to process currently). Since there is a new patch uploaded, we can also mark the older patch as obsolete, so that all the EWS queue do not need to process that patch. EWS skips r- and obsolete patches. Comment on attachment 425159 [details] Patch (In reply to Aakash Jain from comment #7) > I did the r- so that rest of EWS bots do not process that patch (since they > have backlog of patches to process currently). Since there is a new patch > uploaded, we can also mark the older patch as obsolete, so that all the EWS > queue do not need to process that patch. > > EWS skips r- and obsolete patches. I see. In that case, we could mark the patch as obsolete. Committed r275532: <https://commits.webkit.org/r275532> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425184 [details]. |