Bug 224183

Summary: [METAL ANGLE] Stencil only formats being used as the depth attachment.
Product: WebKit Reporter: John Cunningham <johncunningham>
Component: ANGLEAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, johncunningham, jonlee, kkinnunen, kondapallykalyan, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

John Cunningham
Reported 2021-04-05 07:04:14 PDT
Fixes a couple of issues found when using Google Earth, specifically zooming in towards Earth. 1. Stencil only states previously only worked if combined as depth stencil, stencil only formats such as GL_STENCIL_INDEX8 were being incorrectly set as the Metal depth attachment. 2. WebGL contexts issuing many draws and updating a lot of uniforms would have the command encoder be invalidated before they were finished rendering. Previously the command encoder was restarted from an empty state, this change fixes that such that the command buffer and encoder is completely invalidated and the next draw call will set up where the previous command encoder finished. 3. 'Angle_out' transformation was being applied to the result of Angle_swizzle_ref, which may cause issues due to the different address space. I'm not exactly sure what's intended here, but the change looks reasonable and fixes Google Earth. Let the tests run and make sure this doesn't regress something else.
Attachments
Patch (11.94 KB, patch)
2021-04-05 07:11 PDT, John Cunningham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Cunningham
Comment 1 2021-04-05 07:11:18 PDT
Created attachment 425149 [details] Patch
EWS Watchlist
Comment 2 2021-04-05 09:14:31 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Jon Lee
Comment 3 2021-04-05 09:39:47 PDT
rdar://76157243
EWS
Comment 4 2021-04-05 18:17:51 PDT
commit-queue failed to commit attachment 425149 [details] to WebKit repository. To retry, please set cq+ flag again.
Maciej Stachowiak
Comment 5 2021-04-05 18:27:45 PDT
Comment on attachment 425149 [details] Patch Reflagging for CQ. The CQ error seems bogus.
EWS
Comment 6 2021-04-05 19:16:58 PDT
Committed r275476: <https://commits.webkit.org/r275476> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425149 [details].
Note You need to log in before you can comment on or make changes to this bug.