Summary: | Disable WebSQL in WebKitTestRunner | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, ews-watchlist, ggaren, hi, jenner, sihui_liu | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=206627 https://bugs.webkit.org/show_bug.cgi?id=204907 |
||||||||
Attachments: |
|
Description
Ryosuke Niwa
2021-04-02 22:10:10 PDT
Created attachment 425081 [details]
Patch
Created attachment 425192 [details]
Fixed more tests
Comment on attachment 425192 [details] Fixed more tests Clearing flags on attachment: 425192 Committed r275499 (236156@main): <https://commits.webkit.org/236156@main> All reviewed patches have been landed. Closing bug. "storage/websql/alter-to-info-table.html" Had test expectations set that was over-riding the [ Skip ] expectation. Remove the expectations here: https://trac.webkit.org/changeset/277674/webkit Test is a constant failure on wk1 across all platforms. The expectation to skip the storage/websql folder has only been set for wk2. I set a test expectation to skip it for Mac wk1 here: https://trac.webkit.org/changeset/277691/webkit (In reply to Robert Jenner from comment #6) > "storage/websql/alter-to-info-table.html" > > Had test expectations set that was over-riding the [ Skip ] expectation. > Remove the expectations here: > https://trac.webkit.org/changeset/277674/webkit > > Test is a constant failure on wk1 across all platforms. The expectation to > skip the storage/websql folder has only been set for wk2. I set a test > expectation to skip it for Mac wk1 here: > https://trac.webkit.org/changeset/277691/webkit Thanks! It's strange that EWS didn't catch this. |