Bug 224144

Summary: Disable WebSQL in WebKitTestRunner
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, ggaren, hi, jenner, sihui_liu
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206627
https://bugs.webkit.org/show_bug.cgi?id=204907
Attachments:
Description Flags
Patch
none
Fixed more tests none

Description Ryosuke Niwa 2021-04-02 22:10:10 PDT
Disable WebSQL in WebKitTestRunner completely.

These tests had already been disabled in iOS and macOS in https://trac.webkit.org/r255783
but we haven't done so for all other ports.
Comment 1 Ryosuke Niwa 2021-04-02 23:13:22 PDT
Created attachment 425081 [details]
Patch
Comment 2 Ryosuke Niwa 2021-04-02 23:26:11 PDT
<rdar://76179281>
Comment 3 Ryosuke Niwa 2021-04-05 12:59:10 PDT
Created attachment 425192 [details]
Fixed more tests
Comment 4 Ryosuke Niwa 2021-04-06 02:51:55 PDT
Comment on attachment 425192 [details]
Fixed more tests

Clearing flags on attachment: 425192

Committed r275499 (236156@main): <https://commits.webkit.org/236156@main>
Comment 5 Ryosuke Niwa 2021-04-06 02:51:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Robert Jenner 2021-05-18 16:36:02 PDT
"storage/websql/alter-to-info-table.html"

Had test expectations set that was over-riding the [ Skip ] expectation. Remove the expectations here:
https://trac.webkit.org/changeset/277674/webkit

Test is a constant failure on wk1 across all platforms. The expectation to skip the storage/websql folder has only been set for wk2. I set a test expectation to skip it for Mac wk1 here:
https://trac.webkit.org/changeset/277691/webkit
Comment 7 Ryosuke Niwa 2021-05-18 16:36:57 PDT
(In reply to Robert Jenner from comment #6)
> "storage/websql/alter-to-info-table.html"
> 
> Had test expectations set that was over-riding the [ Skip ] expectation.
> Remove the expectations here:
> https://trac.webkit.org/changeset/277674/webkit
> 
> Test is a constant failure on wk1 across all platforms. The expectation to
> skip the storage/websql folder has only been set for wk2. I set a test
> expectation to skip it for Mac wk1 here:
> https://trac.webkit.org/changeset/277691/webkit

Thanks!
Comment 8 Ryosuke Niwa 2021-05-18 16:37:08 PDT
It's strange that EWS didn't catch this.