Bug 224140

Summary: [macOS] Add MediaSessionCoordinator API test
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
ews-feeder: commit-queue-
WIP patch
none
WIP patch
none
WIP, with state change tests
none
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

Eric Carlson
Reported 2021-04-02 16:48:58 PDT
Add basic MediaSessionCoordinator API test
Attachments
WIP patch (72.17 KB, patch)
2021-04-02 16:56 PDT, Eric Carlson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP patch (72.27 KB, patch)
2021-04-02 17:10 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
WIP patch (72.31 KB, patch)
2021-04-03 06:39 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
WIP, with state change tests (78.28 KB, patch)
2021-04-03 11:02 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (73.25 KB, patch)
2021-04-06 10:07 PDT, Eric Carlson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (73.26 KB, patch)
2021-04-06 10:16 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-04-02 16:49:22 PDT
<rdar://problem/76171173>
Eric Carlson
Comment 2 2021-04-02 16:56:48 PDT
Created attachment 425064 [details] WIP patch
Eric Carlson
Comment 3 2021-04-02 17:10:50 PDT
Created attachment 425068 [details] WIP patch
Eric Carlson
Comment 4 2021-04-03 06:39:42 PDT
Created attachment 425094 [details] WIP patch
Eric Carlson
Comment 5 2021-04-03 11:02:36 PDT
Created attachment 425101 [details] WIP, with state change tests
Jer Noble
Comment 6 2021-04-04 11:25:30 PDT
Comment on attachment 425101 [details] WIP, with state change tests View in context: https://bugs.webkit.org/attachment.cgi?id=425101&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:68 > -void WebKit::NetworkSessionCocoa::removeNetworkWebsiteData(WallTime, CompletionHandler<void()>&& completionHandler) { completionHandler(); } > +void WebKit::NetworkSessionCocoa:: (WallTime, CompletionHandler<void()>&& completionHandler) { completionHandler(); } This looks accidental.
Eric Carlson
Comment 7 2021-04-06 10:07:03 PDT
Created attachment 425293 [details] Patch for landing
Eric Carlson
Comment 8 2021-04-06 10:16:32 PDT
Created attachment 425297 [details] Patch for landing
EWS
Comment 9 2021-04-06 12:06:58 PDT
Committed r275537: <https://commits.webkit.org/r275537> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425297 [details].
Note You need to log in before you can comment on or make changes to this bug.