| Summary: | Allow the WebAuthn UI to inform users about BiometryLockout | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, garrett_davidson, jiewen_tan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jiewen Tan
2021-04-02 12:48:20 PDT
Created attachment 425043 [details]
Patch
How did you test this? Comment on attachment 425043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review The test failures on iOS-wk2 don't seem related to this change. r=me > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49 > + if ((!result || error) && error.code != LAErrorBiometryLockout) { Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover? Comment on attachment 425043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49 >> + if ((!result || error) && error.code != LAErrorBiometryLockout) { > > Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover? We just need to let the operation continue. The UI itself has a way to detect the LAErrorBiometryLockout and then inform the user. Comment on attachment 425043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49 >>> + if ((!result || error) && error.code != LAErrorBiometryLockout) { >> >> Should we present any kind of message if the error is LAErrorBiometryLockout? How does the user recover? > > We just need to let the operation continue. The UI itself has a way to detect the LAErrorBiometryLockout and then inform the user. Yep, the UI should take care of it, but we’ve never been able to hit that code path before. Jiewen, can you test this change and send us a bug before landing if that isn’t going to work? commit-queue failed to commit attachment 425043 [details] to WebKit repository. To retry, please set cq+ flag again.
Committed r275492: <https://commits.webkit.org/r275492> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425043 [details]. |