Bug 224088

Summary:

Make sure service workers use a ScriptSourceCode backed by file-mapped memory when possible

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Service Workers

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, simon.fraser, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

224092, 224110

Bug Blocks:

Attachments:

Description	Flags
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	none
WIP Patch	none
Patch	none

Chris Dumez

Reported 2021-04-01 17:42:08 PDT

Make sure service workers use a ScriptSourceCode backed by file-mapped memory whenever possible. This saves dirty memory in the WebProcess.

Attachments
WIP Patch (36.25 KB, patch) 2021-04-01 17:48 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (33.92 KB, patch) 2021-04-02 12:14 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (36.71 KB, patch) 2021-04-02 13:18 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (36.70 KB, patch) 2021-04-02 14:32 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (37.53 KB, patch) 2021-04-02 16:11 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (58.01 KB, patch) 2021-04-02 17:16 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2021-04-01 17:48:02 PDT

Created attachment 424969 [details] WIP Patch Needs polish but with this patch, warm memory usage on my service worker test case with ~200MB of scripts, the WebContent memory usage goes from 231MB to ~23MB. The patch does not take care of the cold case yet.

Chris Dumez

Comment 2 2021-04-02 12:14:09 PDT

Created attachment 425039 [details] WIP Patch

Chris Dumez

Comment 3 2021-04-02 13:18:57 PDT

Created attachment 425046 [details] WIP Patch The patch should now work in both the warm and cold cases. However, I am waiting for the dependency patch to land before I rebase & clean it up.

Chris Dumez

Comment 4 2021-04-02 14:32:54 PDT

Created attachment 425055 [details] WIP Patch

Chris Dumez

Comment 5 2021-04-02 16:11:48 PDT

Created attachment 425063 [details] WIP Patch

Chris Dumez

Comment 6 2021-04-02 17:16:21 PDT

Created attachment 425071 [details] Patch

Yusuke Suzuki

Comment 7 2021-04-05 11:38:08 PDT

Comment on attachment 425071 [details] Patch r=me