Bug 224081

Summary:

Add a macro to help staging logDiagnosticMessageWithDomain in Safari

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Images

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Said Abou-Hallawa 2021-04-01 15:03:20 PDT

This macro will tell whether logDiagnosticMessageWithDomain and _WKDiagnosticLoggingDomain are defined or not. So checking macro will allow building the webkit clients with or without r275103.

Comment 1 Said Abou-Hallawa 2021-04-01 16:12:46 PDT

Created attachment 424959 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2021-04-01 16:39:29 PDT

<rdar://problem/76128509>

Comment 3 Wenson Hsieh 2021-04-01 17:07:45 PDT

Comment on attachment 424959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424959&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:30
> +#define HAS_DIAGNOSTIC_LOGGING_DOMAIN

I think it's common practice to wrap these kinds of `#define`s in `#ifndef/#endif` (though I admittedly can't find many existing examples in WebKit to use as reference :/)

Comment 4 EWS 2021-04-01 22:00:38 PDT

Committed r275404: <https://commits.webkit.org/r275404>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424959 [details].