Bug 224065

Summary: REGRESSION(r274724): JITCage trampoline needs to be adjusted
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, sam, sbarati, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223413
Attachments:
Description Flags
Patch
none
Patch sbarati: review+, ews-feeder: commit-queue-

Description Yusuke Suzuki 2021-04-01 12:17:58 PDT
REGRESSION(r274724): JITCage trampoline needs to be adjusted
Comment 1 Yusuke Suzuki 2021-04-01 12:21:15 PDT
Created attachment 424928 [details]
Patch
Comment 2 Yusuke Suzuki 2021-04-01 12:50:55 PDT
Created attachment 424943 [details]
Patch
Comment 3 Sam Weinig 2021-04-01 13:02:39 PDT
Sorry about that. 

Is there anything you can think to do so that we can do to make this a compile time error in the future? Somehow statically asserting that vmEntryCustomGetter/vmEntryCustomSetter match GetValueFuncWithPtr/PutValueFuncWithPtr?
Comment 4 Yusuke Suzuki 2021-04-01 13:06:44 PDT
(In reply to Sam Weinig from comment #3)
> Sorry about that. 
> 
> Is there anything you can think to do so that we can do to make this a
> compile time error in the future? Somehow statically asserting that
> vmEntryCustomGetter/vmEntryCustomSetter match
> GetValueFuncWithPtr/PutValueFuncWithPtr?

That sounds good! I'll add `static_assert` which checks # of parameter matches with PutValueFuncWithPtr etc. as a first step :)
Comment 5 Yusuke Suzuki 2021-04-01 16:07:03 PDT
Committed r275392 (236056@main): <https://commits.webkit.org/236056@main>
Comment 6 Yusuke Suzuki 2021-04-01 16:07:31 PDT
<rdar://problem/75871161>
Comment 7 Radar WebKit Bug Importer 2021-04-01 16:08:14 PDT
<rdar://problem/76126947>
Comment 8 Sam Weinig 2021-04-02 10:42:20 PDT
(In reply to Yusuke Suzuki from comment #4)
> (In reply to Sam Weinig from comment #3)
> > Sorry about that. 
> > 
> > Is there anything you can think to do so that we can do to make this a
> > compile time error in the future? Somehow statically asserting that
> > vmEntryCustomGetter/vmEntryCustomSetter match
> > GetValueFuncWithPtr/PutValueFuncWithPtr?
> 
> That sounds good! I'll add `static_assert` which checks # of parameter
> matches with PutValueFuncWithPtr etc. as a first step :)

Very nice! Thanks!