Bug 224057

Summary: Expand on shouldComputeLogicalWidthFromAspectRatioAndInsets return logic
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, rbuis, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2021-04-01 11:01:28 PDT
trying to replace "return style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto());" with something easier to parse.
Attachments
Patch (4.46 KB, patch)
2021-04-01 11:04 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (4.64 KB, patch)
2021-04-01 19:48 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-04-01 11:04:19 PDT
Created attachment 424913 [details] Patch
Rob Buis
Comment 2 2021-04-01 13:56:05 PDT
Comment on attachment 424913 [details] Patch This looks good to me once the commit message is fixed. Thanks for working on this :)
zalan
Comment 3 2021-04-01 19:48:54 PDT
Created attachment 424980 [details] Patch
zalan
Comment 4 2021-04-01 20:48:14 PDT
(In reply to Rob Buis from comment #2) > Comment on attachment 424913 [details] > Patch > > This looks good to me once the commit message is fixed. Thanks for the review! >Thanks for working on this :) I am trying to figure out an infinite recursion bug and I realized I should have involved myself more during the initial patch reviews. It's all new to me now.
EWS
Comment 5 2021-04-01 21:02:10 PDT
Committed r275402: <https://commits.webkit.org/r275402> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424980 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-01 21:03:15 PDT
<rdar://problem/76136339>
Note You need to log in before you can comment on or make changes to this bug.