Bug 224008

Summary: [webkitscmpy] Improve git-svn-id regex
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq] Patch
none
[fast-cq] Patch for landing none

Jonathan Bedard
Reported 2021-03-31 11:35:46 PDT
A git-svn-id is only valid if it is at the beginning of a new line, otherwise, the regex may be matching the git-svn-id of a cherry-picked commit contained inside a given commit. Additionally, it turns out that our mock Git code was generating incorrect git-svn-id lines, but we didn't notice because stripping off the first 4 characters results in "svn-id", which seemed correct enough that we enshrined it in our unit tests.
Attachments
[fast-cq] Patch (8.09 KB, patch)
2021-03-31 11:41 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch for landing (7.51 KB, patch)
2021-04-01 04:29 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-31 11:35:58 PDT
<rdar://problem/76062561>
Jonathan Bedard
Comment 2 2021-03-31 11:41:57 PDT
Created attachment 424794 [details] [fast-cq] Patch
Aakash Jain
Comment 3 2021-03-31 15:27:12 PDT
Comment on attachment 424794 [details] [fast-cq] Patch rs=me
EWS
Comment 4 2021-04-01 04:21:23 PDT
Tools/Scripts/svn-apply failed to apply attachment 424794 [details] to trunk. Please resolve the conflicts and upload a new patch.
Aakash Jain
Comment 5 2021-04-01 04:29:52 PDT
Created attachment 424884 [details] [fast-cq] Patch for landing Resolved conflict by updating version in setup.py and __init__.py
EWS
Comment 6 2021-04-01 04:36:24 PDT
Committed r275353 (?): <https://commits.webkit.org/r275353> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424884 [details].
Note You need to log in before you can comment on or make changes to this bug.