Bug 224008

Summary: [webkitscmpy] Improve git-svn-id regex
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq] Patch
none
[fast-cq] Patch for landing none

Description Jonathan Bedard 2021-03-31 11:35:46 PDT
A git-svn-id is only valid if it is at the beginning of a new line, otherwise, the regex may be matching the git-svn-id of a cherry-picked commit contained inside a given commit. Additionally, it turns out that our mock Git code was generating incorrect git-svn-id lines, but we didn't notice because stripping off the first 4 characters results in "svn-id", which seemed correct enough that we enshrined it in our unit tests.
Comment 1 Radar WebKit Bug Importer 2021-03-31 11:35:58 PDT
<rdar://problem/76062561>
Comment 2 Jonathan Bedard 2021-03-31 11:41:57 PDT
Created attachment 424794 [details]
[fast-cq] Patch
Comment 3 Aakash Jain 2021-03-31 15:27:12 PDT
Comment on attachment 424794 [details]
[fast-cq] Patch

rs=me
Comment 4 EWS 2021-04-01 04:21:23 PDT
Tools/Scripts/svn-apply failed to apply attachment 424794 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 5 Aakash Jain 2021-04-01 04:29:52 PDT
Created attachment 424884 [details]
[fast-cq] Patch for landing

Resolved conflict by updating version in setup.py and __init__.py
Comment 6 EWS 2021-04-01 04:36:24 PDT
Committed r275353 (?): <https://commits.webkit.org/r275353>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424884 [details].