Bug 223999

Summary: Make use of NSURLSessionWebSocket.sendCloseCode if available
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2021-03-31 08:25:53 PDT
Make use of NSURLSessionWebSocket.sendCloseCode if available
Attachments
Patch (2.05 KB, patch)
2021-03-31 08:29 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (2.70 KB, patch)
2021-03-31 10:12 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-03-31 08:29:37 PDT
Created attachment 424772 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-03-31 09:01:51 PDT
<rdar://problem/76055268>
Sam Weinig
Comment 3 2021-03-31 09:27:42 PDT
Comment on attachment 424772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424772&action=review > Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm:42 > +@interface NSURLSessionWebSocketTask (SPI) > +// Send close frame but do not cancel the task > +- (void)_sendCloseCode:(NSURLSessionWebSocketCloseCode)closeCode reason:(NSData *)reason; > +@end Please put SPI declarations into the CFNetworkSPI.h header.
Alex Christensen
Comment 4 2021-03-31 10:12:09 PDT
Created attachment 424785 [details] Patch
EWS
Comment 5 2021-03-31 11:13:08 PDT
Committed r275294: <https://commits.webkit.org/r275294> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424785 [details].
Note You need to log in before you can comment on or make changes to this bug.