Bug 223999

Summary: Make use of NSURLSessionWebSocket.sendCloseCode if available
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2021-03-31 08:25:53 PDT
Make use of NSURLSessionWebSocket.sendCloseCode if available
Comment 1 youenn fablet 2021-03-31 08:29:37 PDT
Created attachment 424772 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-03-31 09:01:51 PDT
<rdar://problem/76055268>
Comment 3 Sam Weinig 2021-03-31 09:27:42 PDT
Comment on attachment 424772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424772&action=review

> Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm:42
> +@interface NSURLSessionWebSocketTask (SPI)
> +// Send close frame but do not cancel the task
> +- (void)_sendCloseCode:(NSURLSessionWebSocketCloseCode)closeCode reason:(NSData *)reason;
> +@end

Please put SPI declarations into the CFNetworkSPI.h header.
Comment 4 Alex Christensen 2021-03-31 10:12:09 PDT
Created attachment 424785 [details]
Patch
Comment 5 EWS 2021-03-31 11:13:08 PDT
Committed r275294: <https://commits.webkit.org/r275294>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424785 [details].