| Summary: | Assertions in DisplayUpdate when dragging WebView windows between screens with different refresh rates | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | WebCore Misc. | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | sam, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2021-03-30 21:29:02 PDT
Created attachment 424733 [details]
Patch
Created attachment 424734 [details]
Patch
Comment on attachment 424734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424734&action=review > Source/WebCore/page/Chrome.cpp:549 > +void Chrome::windowScreenDidChange(PlatformDisplayID displayID, Optional<FramesPerSecond> nominalFrameInterval) Seems like at some point we should add a "PlatformDisplay" or "PlatformScreen" object that can package these. > Source/WebCore/page/Page.cpp:1186 > + // If the caller didn't give us a refresh rate, maybe the relevant DisplayRefreshMonitor can? This happens in WebKitLegacy. Can you add a little bit more detail about why this can happen in WebKitLegacy? |