| Summary: | Add Options::exitOnResourceExhaustion() to enable exiting instead of crashing on resource exhaustion. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, ews-watchlist, gyuyoung.kim, keith_miller, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2021-03-30 14:54:08 PDT
Created attachment 424704 [details]
proposed patch.
Comment on attachment 424704 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=424704&action=review r=me > Source/JavaScriptCore/runtime/ResourceExhaustion.cpp:36 > + WTFReportAssertionFailureWithMessage(file, line, function, assertion, "ResourceExhaustion(%d): %s", static_cast<int>(exitCode), failureMessage); Since this isn't called directly, you could use the macro to stringify the ResourceExhaustionCode. Comment on attachment 424704 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=424704&action=review Thanks for the review. >> Source/JavaScriptCore/runtime/ResourceExhaustion.cpp:36 >> + WTFReportAssertionFailureWithMessage(file, line, function, assertion, "ResourceExhaustion(%d): %s", static_cast<int>(exitCode), failureMessage); > > Since this isn't called directly, you could use the macro to stringify the ResourceExhaustionCode. I had debated back and forth on whether I should do this initially. I think I'll go with adding the stringified code. Landed in r275243: <http://trac.webkit.org/r275243>. |