Bug 223959

Summary: Add Options::exitOnResourceExhaustion() to enable exiting instead of crashing on resource exhaustion.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. tzagallo: review+

Mark Lam
Reported 2021-03-30 14:54:08 PDT
This is useful to unblock fuzzers from false positive crashes due to resource exhaustion. rdar://63934158
Attachments
proposed patch. (12.92 KB, patch)
2021-03-30 15:01 PDT, Mark Lam 		tzagallo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-03-30 15:01:32 PDT
Created attachment 424704 [details] proposed patch.
Tadeu Zagallo
Comment 2 2021-03-30 15:24:42 PDT
Comment on attachment 424704 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=424704&action=review r=me > Source/JavaScriptCore/runtime/ResourceExhaustion.cpp:36 > + WTFReportAssertionFailureWithMessage(file, line, function, assertion, "ResourceExhaustion(%d): %s", static_cast<int>(exitCode), failureMessage); Since this isn't called directly, you could use the macro to stringify the ResourceExhaustionCode.
Mark Lam
Comment 3 2021-03-30 15:41:35 PDT
Comment on attachment 424704 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=424704&action=review Thanks for the review. >> Source/JavaScriptCore/runtime/ResourceExhaustion.cpp:36 >> + WTFReportAssertionFailureWithMessage(file, line, function, assertion, "ResourceExhaustion(%d): %s", static_cast<int>(exitCode), failureMessage); > > Since this isn't called directly, you could use the macro to stringify the ResourceExhaustionCode. I had debated back and forth on whether I should do this initially. I think I'll go with adding the stringified code.
Mark Lam
Comment 4 2021-03-30 15:47:55 PDT
Landed in r275243: <http://trac.webkit.org/r275243>.
Note You need to log in before you can comment on or make changes to this bug.