Bug 223958

Summary: Web Inspector: [Cocoa] WKInspectorResourceURLSchemeHandler can exceed the soft thread limit when opening multiple inspectors simultaneously.
Product: WebKit Reporter: Patrick Angle <pangle>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1.0
none
Patch v1.1 - Shorten redundant part of comment none

Patrick Angle
Reported 2021-03-30 14:41:57 PDT
Multiple WKInspectorResourceURLSchemeHandlers may be loading inspectors at the same time, which makes it possible for their combined operations to exceed the soft thread limit. In practice, this should only possible in engineering builds.
Attachments
Patch v1.0 (2.65 KB, patch)
2021-03-30 14:51 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.1 - Shorten redundant part of comment (2.54 KB, patch)
2021-03-31 19:02 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick Angle
Comment 1 2021-03-30 14:47:25 PDT
<rdar://75847924>
Patrick Angle
Comment 2 2021-03-30 14:51:36 PDT
Created attachment 424701 [details] Patch v1.0
Blaze Burg
Comment 3 2021-03-31 15:30:28 PDT
Comment on attachment 424701 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=424701&action=review r=me > Source/WebKit/UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.mm:62 > + // The default value (NSOperationQueueDefaultMaxConcurrentOperationCount) results in a large number of threads I think this second comment is nice but redundant with the changelog, and could be removed.
Patrick Angle
Comment 4 2021-03-31 19:02:21 PDT
Created attachment 424862 [details] Patch v1.1 - Shorten redundant part of comment
EWS
Comment 5 2021-03-31 19:31:23 PDT
Committed r275341: <https://commits.webkit.org/r275341> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424862 [details].
Note You need to log in before you can comment on or make changes to this bug.