Bug 223928

Summary: Optimize createListFromArrayLike() and Proxy's [[OwnPropertyKeys]] method
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Enhancement CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alexey Shvayka
Reported 2021-03-30 07:02:19 PDT
Optimize createListFromArrayLike() and Proxy's [[OwnPropertyKeys]] method
Attachments
Patch (17.91 KB, patch)
2021-03-30 07:05 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (19.52 KB, patch)
2021-03-30 13:47 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (18.57 KB, patch)
2021-03-30 16:34 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2021-03-30 07:05:19 PDT
Created attachment 424635 [details] Patch
Alexey Shvayka
Comment 2 2021-03-30 07:05:59 PDT
(In reply to Alexey Shvayka from comment #1) > Created attachment 424635 [details] > Patch r274349 patch reflect-own-keys-proxy 69.1157+-1.3454 ^ 53.2344+-0.8644 ^ definitely 1.2983x faster reflect-own-keys-proxy-2 75.4748+-0.8499 ^ 62.5830+-0.8780 ^ definitely 1.2060x faster <geometric> 72.2098+-0.9571 ^ 57.7050+-0.6808 ^ definitely 1.2514x faster
Alexey Shvayka
Comment 3 2021-03-30 13:47:41 PDT
Created attachment 424689 [details] Patch Make JSArrayInlines.h a private header to fix WebCore build.
Alexey Shvayka
Comment 4 2021-03-30 16:34:55 PDT
Created attachment 424714 [details] Patch Add JSArrayInlines.h to CMakeLists.txt and remove uint32_t getIndex() override.
Yusuke Suzuki
Comment 5 2021-04-01 00:40:54 PDT
Comment on attachment 424714 [details] Patch r=me
EWS
Comment 6 2021-04-01 09:07:15 PDT
Committed r275363: <https://commits.webkit.org/r275363> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424714 [details].
Radar WebKit Bug Importer
Comment 7 2021-04-01 09:08:16 PDT
<rdar://problem/76106345>
Note You need to log in before you can comment on or make changes to this bug.