Summary: | Add a test for the HTMLOptionsCollection indexed setter | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pam Greene (IRC:pamg) <pam> | ||||||
Component: | DOM | Assignee: | Pam Greene (IRC:pamg) <pam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pam Greene (IRC:pamg)
2008-11-20 11:44:52 PST
Created attachment 25321 [details]
New test + result
Comment on attachment 25321 [details]
New test + result
r=me
It's a little sad to have these one-off tests when they could easily be changed to have more coverage. It makes our test suite run a lot faster when individual tests can test more than one closely-related thing.
Created attachment 25323 [details]
Better new test, checks function-style getter too
Combining the next one on my list with this one, and using the JS wrapper. Sorry for the wasted previous review.
Comment on attachment 25321 [details]
New test + result
Clearing r+ on obsolete patch.
Comment on attachment 25323 [details]
Better new test, checks function-style getter too
r=me
|