Bug 22387

Summary: Add a test for the HTMLOptionsCollection indexed setter
Product: WebKit Reporter: Pam Greene (IRC:pamg) <pam>
Component: DOMAssignee: Pam Greene (IRC:pamg) <pam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
New test + result
none
Better new test, checks function-style getter too darin: review+

Description Pam Greene (IRC:pamg) 2008-11-20 11:44:52 PST
Simple test.
Comment 1 Pam Greene (IRC:pamg) 2008-11-20 11:48:02 PST
Created attachment 25321 [details]
New test + result
Comment 2 Darin Adler 2008-11-20 11:52:02 PST
Comment on attachment 25321 [details]
New test + result

r=me

It's a little sad to have these one-off tests when they could easily be changed to have more coverage. It makes our test suite run a lot faster when individual tests can test more than one closely-related thing.
Comment 3 Pam Greene (IRC:pamg) 2008-11-20 13:52:39 PST
Created attachment 25323 [details]
Better new test, checks function-style getter too

Combining the next one on my list with this one, and using the JS wrapper.  Sorry for the wasted previous review.
Comment 4 Pam Greene (IRC:pamg) 2008-11-20 13:53:28 PST
Comment on attachment 25321 [details]
New test + result

Clearing r+ on obsolete patch.
Comment 5 Darin Adler 2008-11-20 14:07:12 PST
Comment on attachment 25323 [details]
Better new test, checks function-style getter too

r=me
Comment 6 Pam Greene (IRC:pamg) 2008-11-20 15:20:24 PST
Landed in r38633.