Summary: | [GPU Process] Simplify DisplayList::Iterator part 1: Require encoding/decoding delegates for non-inline display list items | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | annulen, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, pdr, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 223560 | ||||||||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2021-03-28 01:37:12 PDT
Created attachment 424486 [details]
Patch
Created attachment 424508 [details]
Patch
Created attachment 424519 [details]
Patch
Comment on attachment 424519 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424519&action=review > Source/WebCore/html/HTMLCanvasElement.cpp:49 > +#include "InMemoryDisplayList.h" Do we need this include? > Source/WebCore/platform/graphics/displaylists/InMemoryDisplayList.cpp:64 > + for (auto iterator = this->begin(); iterator != end; ++iterator) { Can we just do something like `for (auto [item, extent, size] : *this) { …` here instead? > Source/WebCore/platform/graphics/displaylists/InMemoryDisplayList.h:55 > + std::unique_ptr<ItemBufferWritingClient> m_writingClient; > + std::unique_ptr<ItemBufferReadingClient> m_readingClient; Should these be of type `InMemoryDisplayList::WritingClient` and `InMemoryDisplayList::ReadingClient`? (i.e. do we expect these to be set to non-in-memory clients)? Created attachment 424523 [details]
Patch
Created attachment 424527 [details]
Patch
Comment on attachment 424527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424527&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h:59 > + m_drawingContext.displayList().setItemBufferClient(m_writingClient.get()); > + m_drawingContext.displayList().setItemBufferClient(m_readingClient.get()); It looks like this needs to be updated after the recent renaming. Created attachment 425057 [details]
Patch for committing
Committed r275459: <https://commits.webkit.org/r275459> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425057 [details]. |