Bug 223835

Summary:

[LayoutTests] Convert http/tests/contentextensions convert PHP to Python

Product:

WebKit

Reporter:

Chris Gambrell <cgambrell>

Component:

Tools / Tests

Assignee:

Chris Gambrell <cgambrell>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, ews-watchlist, hi, jbedard, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=220749
https://bugs.webkit.org/show_bug.cgi?id=223965

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-

Chris Gambrell

Reported 2021-03-26 19:51:25 PDT

Replacing PHP with equivalent Python CGI scripts

Attachments
Patch (74.58 KB, patch) 2021-03-26 19:53 PDT, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (76.73 KB, patch) 2021-03-29 17:04 PDT, Chris Gambrell	no flags	Details Formatted Diff Diff
Patch (75.38 KB, patch) 2021-03-30 07:43 PDT, Chris Gambrell	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-03-26 19:51:46 PDT

<rdar://problem/75912102>

Chris Gambrell

Comment 2 2021-03-26 19:53:26 PDT

Created attachment 424435 [details] Patch

Chris Gambrell

Comment 3 2021-03-26 20:01:59 PDT

Comment on attachment 424435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424435&action=review > LayoutTests/http/tests/contentextensions/resources/save_ping.py:8 > +class SavePing: Had to do a hack-y way of sending variables to this class when including it for save_ping.py, save-ping.py, and save-ping-and-redirect-to-save-ping.py.

Jonathan Bedard

Comment 4 2021-03-29 09:22:49 PDT

Comment on attachment 424435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424435&action=review >> LayoutTests/http/tests/contentextensions/resources/save_ping.py:8 >> +class SavePing: > > Had to do a hack-y way of sending variables to this class when including it for save_ping.py, save-ping.py, and save-ping-and-redirect-to-save-ping.py. I'm a unclear as to why SavePing is a class and not a function, it seems like function is the more natural choice here.

Chris Gambrell

Comment 5 2021-03-29 17:04:38 PDT

Created attachment 424603 [details] Patch

Chris Gambrell

Comment 6 2021-03-30 07:43:42 PDT

Created attachment 424638 [details] Patch

Jonathan Bedard

Comment 7 2021-03-30 07:56:27 PDT

To be clear, r+ on this change, Chris and I were talking on Slack, I neglected to actually publicize my r+.

EWS

Comment 8 2021-03-30 08:20:27 PDT

Committed r275204: <https://commits.webkit.org/r275204> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424638 [details].

Note You need to log in before you can comment on or make changes to this bug.