Bug 223834

Summary: REGRESSION(r275111) [GLIB] Fix build with new derived sources and forwarding headers scheme
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: WebKitGTKAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Lauro Moura
Reported 2021-03-26 19:42:46 PDT
REGRESSION(r271111) [GLIB] Fix build with new derived sources and forwarding headers scheme
Attachments
Patch (3.77 KB, patch)
2021-03-26 19:44 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2021-03-26 19:44:29 PDT
Created attachment 424434 [details] Patch
Lauro Moura
Comment 2 2021-03-26 20:10:25 PDT
Committed r275127 (235832@main): <https://commits.webkit.org/235832@main>
Lauro Moura
Comment 3 2021-03-26 22:13:24 PDT
Still failing on the bots
Philippe Normand
Comment 4 2021-03-27 03:41:53 PDT
GTK Broken too: ../../Source/JavaScriptCore/API/glib/JSCVersion.cpp:21:10: fatal error: 'JSCVersion.h' file not found #include "JSCVersion.h" ^~~~~~~~~~~~~~ A full clean build works, somehow. But then an incremental build (even without any local change) breaks this way. I see no generated JSCVersion.h file whatsoever.
Philippe Normand
Comment 5 2021-03-27 03:53:00 PDT
https://trac.webkit.org/changeset/275132/webkit
Lauro Moura
Comment 6 2021-03-27 06:48:15 PDT
(In reply to Philippe Normand from comment #5) > https://trac.webkit.org/changeset/275132/webkit Builders green. Thanks for the fix!
Note You need to log in before you can comment on or make changes to this bug.