Bug 223831

Summary: Migrate _WKUserContentExtension and older versions of WKContentRuleList to WKContentRuleList during lookup
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, berto, cgarcia, ews-watchlist, gustavo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2021-03-26 17:40:53 PDT
Migrate _WKUserContentExtension and older versions of WKContentRuleList to WKContentRuleList during lookup
Attachments
Patch (41.39 KB, patch)
2021-03-26 17:49 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (41.98 KB, patch)
2021-03-29 09:57 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (41.65 KB, patch)
2021-03-29 10:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-03-26 17:49:29 PDT
Created attachment 424425 [details] Patch
Alex Christensen
Comment 2 2021-03-29 09:57:55 PDT
Created attachment 424539 [details] Patch
EWS Watchlist
Comment 3 2021-03-29 09:59:14 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 4 2021-03-29 10:14:22 PDT
Created attachment 424541 [details] Patch
Brady Eidson
Comment 5 2021-03-29 10:51:44 PDT
Comment on attachment 424541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424541&action=review > Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:82 > +// FIXME: Remove legacyFilename in 2022 or 2023 after users have had a chance to run the updating logic. HAH
EWS
Comment 6 2021-03-29 11:12:29 PDT
Committed r275166: <https://commits.webkit.org/r275166> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424541 [details].
Radar WebKit Bug Importer
Comment 7 2021-03-29 11:13:13 PDT
<rdar://problem/75963021>
Note You need to log in before you can comment on or make changes to this bug.