Bug 223823 – WebFeature class fails to copy/retain its instance variables

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

WebFeature class fails to copy/retain its instance variables despite what its @property declarations state.

To fix this, I'm just going to add -copy methods in the init method, and add a -dealloc method that can be deleted when switching to ARC.

Using RetainPtr<> for this class seems overkill.

[David Kilzer (:ddkilzer)]

Created attachment 424412 [details]
Patch v1

[Sam Weinig]

Comment on attachment 424412 [details]
Patch v1

I think Chris is trying to use RetainPtr everywhere, so we probably should here too, but you don't have to in this patch. I can do so in a follow up.

[EWS]

Committed r275131: <https://commits.webkit.org/r275131>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424412 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75913890>

[David Kilzer (:ddkilzer)]

(In reply to Sam Weinig from comment #2)
> Comment on attachment 424412 [details]
> Patch v1
> 
> I think Chris is trying to use RetainPtr everywhere, so we probably should
> here too, but you don't have to in this patch. I can do so in a follow up.

Those were some speculative fixes to try to resolve some CoreIPC crashes if I remember correctly.  I appreciate you offering to follow up on this.