Summary: | WebFeature class fails to copy/retain its instance variables | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | sam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2021-03-26 15:56:41 PDT
Created attachment 424412 [details]
Patch v1
Comment on attachment 424412 [details]
Patch v1
I think Chris is trying to use RetainPtr everywhere, so we probably should here too, but you don't have to in this patch. I can do so in a follow up.
Committed r275131: <https://commits.webkit.org/r275131> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424412 [details]. (In reply to Sam Weinig from comment #2) > Comment on attachment 424412 [details] > Patch v1 > > I think Chris is trying to use RetainPtr everywhere, so we probably should > here too, but you don't have to in this patch. I can do so in a follow up. Those were some speculative fixes to try to resolve some CoreIPC crashes if I remember correctly. I appreciate you offering to follow up on this. |