Bug 223818

Summary: VoiceOver does not echo text insertions and deletions when a contenteditable div has a non editable descendant element with a content editable child
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Andres Gonzalez 2021-03-26 14:04:56 PDT 
VoiceOver does not echo text insertions and deletions when a contenteditable div has a non editable descendant element with a content editable child
Comment 1 Radar WebKit Bug Importer 2021-03-26 14:05:04 PDT 
<rdar://problem/75900717>
Comment 2 Andres Gonzalez 2021-03-26 14:23:30 PDT 
Created attachment 424404 [details]
Patch
Comment 3 chris fleizach 2021-03-26 14:27:19 PDT 
Comment on attachment 424404 [details]
Patch

is there a layout test that can be added?
Comment 4 Andres Gonzalez 2021-04-07 15:32:35 PDT 
Created attachment 425447 [details]
Patch
Comment 5 Andres Gonzalez 2021-04-07 15:33:51 PDT 
(In reply to chris fleizach from comment #3)
> Comment on attachment 424404 [details]
> Patch
> 
> is there a layout test that can be added?

Added layout test.
Comment 6 chris fleizach 2021-04-07 15:34:54 PDT 
Comment on attachment 425447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425447&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:994
> +        // FIXME: why walk up the hierarchy of RenderObjects instead of AXObjects?

should we change this to AXObject tree and verify no tests fail?
Comment 7 Andres Gonzalez 2021-04-07 17:03:23 PDT 
Created attachment 425459 [details]
Patch
Comment 8 Andres Gonzalez 2021-04-07 17:04:40 PDT 
(In reply to chris fleizach from comment #6)
> Comment on attachment 425447 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425447&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:994
> > +        // FIXME: why walk up the hierarchy of RenderObjects instead of AXObjects?
> 
> should we change this to AXObject tree and verify no tests fail?

Done.
Comment 9 Andres Gonzalez 2021-04-07 17:16:55 PDT 
Created attachment 425462 [details]
Patch
Comment 10 Andres Gonzalez 2021-04-07 17:18:32 PDT 
(In reply to Andres Gonzalez from comment #9)
> Created attachment 425462 [details]
> Patch

Skip test in Mac-wk1.
Comment 11 Andres Gonzalez 2021-04-08 07:51:14 PDT 
Created attachment 425507 [details]
Patch
Comment 12 Andres Gonzalez 2021-04-08 07:52:28 PDT 
(In reply to Andres Gonzalez from comment #11)
> Created attachment 425507 [details]
> Patch

Skip test in Win.
Comment 13 EWS 2021-04-08 11:23:10 PDT 
Committed r275664 (236300@main): <https://commits.webkit.org/236300@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425507 [details].