Bug 223817

Summary: [GPU process] Enable CFPrefs direct mode
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+, ews-feeder: commit-queue-
Patch none

Per Arne Vollan
Reported 2021-03-26 13:48:40 PDT
Enable CFPrefs direct mode in the GPU process.
Attachments
Patch (8.82 KB, patch)
2021-03-26 13:54 PDT, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (8.97 KB, patch)
2021-04-01 07:32 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-03-26 13:54:04 PDT
Created attachment 424401 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-03-26 14:01:28 PDT
Do you have any data on the memory impact?
Per Arne Vollan
Comment 3 2021-03-29 09:31:40 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Do you have any data on the memory impact? I am running tests now :) Thanks for reviewing!
Brent Fulgham
Comment 4 2021-03-31 12:55:26 PDT
Comment on attachment 424401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424401&action=review R=me > Source/WebKit/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=223817 Radar, please. > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:579 > +(allow file-read* Please add Literal “/Library/Preferences/.GlobalOreferences.plist”, too. > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:580 > + (home-subpath "/Library/Preferences/.GlobalPreferences.plist") Please add .GlobalPreferences_m.plist’ too.
Per Arne Vollan
Comment 5 2021-04-01 07:32:57 PDT
Created attachment 424895 [details] Patch
EWS
Comment 6 2021-04-01 08:16:00 PDT
commit-queue failed to commit attachment 424895 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 7 2021-04-01 10:38:32 PDT
Committed r275367: <https://commits.webkit.org/r275367> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424895 [details].
Radar WebKit Bug Importer
Comment 8 2021-04-01 10:40:36 PDT
<rdar://problem/76110432>
Note You need to log in before you can comment on or make changes to this bug.