Bug 223810

Summary:

Remove ENABLE_INDEXED_DATABASE & ENABLE_INDEXED_DATABASE_IN_WORKERS, it seems like it is on for all ports

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

WebKit Misc.

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, annulen, beidson, benjamin, calvaris, cdumez, cmarcelo, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, japhet, jbedard, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, mark.lam, msaboff, ryuan.choi, saam, sergio, simon.fraser, tzagallo, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none

Sam Weinig

Reported 2021-03-26 12:12:11 PDT

As far as I can tell, ENABLE_INDEXED_DATABASE_IN_WORKERS is enabled for all ports. It is on for the cocoa ports via PlatformEnableCocoa.h. It is on for the non-cocoa ports via WebKitFeatures.cmake.

Attachments
Patch (182.09 KB, patch) 2021-03-26 17:13 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (182.28 KB, patch) 2021-03-26 17:20 PDT, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (184.64 KB, patch) 2021-03-26 19:27 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2021-03-26 14:36:23 PDT

Seems like this is also true for ENABLE_INDEXED_DATABASE. Let's do both.

Sam Weinig

Comment 2 2021-03-26 17:13:51 PDT Comment hidden (obsolete)

Created attachment 424422 [details] Patch

Sam Weinig

Comment 3 2021-03-26 17:20:31 PDT Comment hidden (obsolete)

Created attachment 424423 [details] Patch

EWS Watchlist

Comment 4 2021-03-26 17:21:53 PDT Comment hidden (obsolete)

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

Sam Weinig

Comment 5 2021-03-26 19:27:24 PDT

Created attachment 424432 [details] Patch

Sam Weinig

Comment 6 2021-03-27 11:37:04 PDT

Any inspector folk know what's going on with the Windows's build? C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(46,84): error C2039: 'IndexedDBBackendDispatcherHandler': is not a member of 'Inspector' (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-2.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(38): message : see declaration of 'Inspector' (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-2.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(46,118): error C2504: 'IndexedDBBackendDispatcherHandler': base class undefined (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-2.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(60,65): error C2065: 'RequestDatabaseNamesCallback': undeclared identifier (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-2.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(60,61): error C2923: 'WTF::Ref': 'RequestDatabaseNamesCallback' is not a valid template type argument for parameter 'T' (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-2.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]

Sam Weinig

Comment 7 2021-03-27 18:55:23 PDT

(In reply to Sam Weinig from comment #6) > Any inspector folk know what's going on with the Windows's build? > > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(46,84): > error C2039: 'IndexedDBBackendDispatcherHandler': is not a member of > 'Inspector' (compiling source file > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified- > sources\UnifiedSource-84c9f43f-2.cpp) > [C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(38): > message : see declaration of 'Inspector' (compiling source file > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified- > sources\UnifiedSource-84c9f43f-2.cpp) > [C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(46,118): > error C2504: 'IndexedDBBackendDispatcherHandler': base class undefined > (compiling source file > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified- > sources\UnifiedSource-84c9f43f-2.cpp) > [C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(60,65): > error C2065: 'RequestDatabaseNamesCallback': undeclared identifier > (compiling source file > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified- > sources\UnifiedSource-84c9f43f-2.cpp) > [C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(60,61): > error C2923: 'WTF::Ref': 'RequestDatabaseNamesCallback' is not a valid > template type argument for parameter 'T' (compiling source file > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified- > sources\UnifiedSource-84c9f43f-2.cpp) > [C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] I have been told this is just to be expected from the Windows port. So please ignore.

EWS

Comment 8 2021-03-28 12:14:27 PDT

Committed r275151: <https://commits.webkit.org/r275151> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424432 [details].

Radar WebKit Bug Importer

Comment 9 2021-03-28 12:15:16 PDT

<rdar://problem/75934037>

Note You need to log in before you can comment on or make changes to this bug.