Bug 223763

Summary:

[CMake] Deprecate using DERIVED_SOURCES_DIR/FOWARDING_HEADERS_DIR directly

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

CMake

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, tzagallo

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	ews-feeder: commit-queue-
WIP Patch	none
WIP Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Don Olmstead

Reported 2021-03-25 14:41:53 PDT

....

Attachments
WIP Patch (28.81 KB, patch) 2021-03-25 14:43 PDT, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (28.89 KB, patch) 2021-03-25 14:47 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (28.95 KB, patch) 2021-03-25 14:48 PDT, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (34.54 KB, patch) 2021-03-26 07:39 PDT, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (34.70 KB, patch) 2021-03-26 09:41 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2021-03-25 14:43:22 PDT Comment hidden (obsolete)

Created attachment 424280 [details] WIP Patch

Don Olmstead

Comment 2 2021-03-25 14:47:23 PDT Comment hidden (obsolete)

Created attachment 424281 [details] WIP Patch

Don Olmstead

Comment 3 2021-03-25 14:48:57 PDT Comment hidden (obsolete)

Created attachment 424282 [details] WIP Patch

Don Olmstead

Comment 4 2021-03-26 07:39:07 PDT Comment hidden (obsolete)

Created attachment 424350 [details] Patch

Don Olmstead

Comment 5 2021-03-26 09:41:29 PDT

Created attachment 424366 [details] Patch

Michael Catanzaro

Comment 6 2021-03-26 09:49:49 PDT

Comment on attachment 424366 [details] Patch LGTM

Don Olmstead

Comment 7 2021-03-26 12:37:16 PDT

(In reply to Michael Catanzaro from comment #6) > Comment on attachment 424366 [details] > Patch > > LGTM Looks like the GTK failure was just the bot. It’s green now.

EWS

Comment 8 2021-03-26 13:37:15 PDT

Committed r275111: <https://commits.webkit.org/r275111> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424366 [details].

Note You need to log in before you can comment on or make changes to this bug.