Summary: | [CMake] Deprecate using DERIVED_SOURCES_DIR/FOWARDING_HEADERS_DIR directly | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||||||
Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | annulen, aperez, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, tzagallo | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Don Olmstead
2021-03-25 14:41:53 PDT
Created attachment 424280 [details]
WIP Patch
Created attachment 424281 [details]
WIP Patch
Created attachment 424282 [details]
WIP Patch
Created attachment 424350 [details]
Patch
Created attachment 424366 [details]
Patch
Comment on attachment 424366 [details]
Patch
LGTM
(In reply to Michael Catanzaro from comment #6) > Comment on attachment 424366 [details] > Patch > > LGTM Looks like the GTK failure was just the bot. It’s green now. Committed r275111: <https://commits.webkit.org/r275111> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424366 [details]. |