Bug 223763 - [CMake] Deprecate using DERIVED_SOURCES_DIR/FOWARDING_HEADERS_DIR directly
Summary: [CMake] Deprecate using DERIVED_SOURCES_DIR/FOWARDING_HEADERS_DIR directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-25 14:41 PDT by Don Olmstead
Modified: 2021-03-26 13:37 PDT (History)
12 users (show)

See Also:

Attachments
WIP Patch (28.81 KB, patch)
2021-03-25 14:43 PDT, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (28.89 KB, patch)
2021-03-25 14:47 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
WIP Patch (28.95 KB, patch)
2021-03-25 14:48 PDT, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (34.54 KB, patch)
2021-03-26 07:39 PDT, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (34.70 KB, patch)
2021-03-26 09:41 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-03-25 14:41:53 PDT 
....
Comment 1 Don Olmstead 2021-03-25 14:43:22 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2021-03-25 14:47:23 PDT Comment hidden (obsolete)
Comment 3 Don Olmstead 2021-03-25 14:48:57 PDT Comment hidden (obsolete)
Comment 4 Don Olmstead 2021-03-26 07:39:07 PDT Comment hidden (obsolete)
Comment 5 Don Olmstead 2021-03-26 09:41:29 PDT 
Created attachment 424366 [details]
Patch
Comment 6 Michael Catanzaro 2021-03-26 09:49:49 PDT 
Comment on attachment 424366 [details]
Patch

LGTM
Comment 7 Don Olmstead 2021-03-26 12:37:16 PDT 
(In reply to Michael Catanzaro from comment #6)
> Comment on attachment 424366 [details]
> Patch
> 
> LGTM

Looks like the GTK failure was just the bot. It’s green now.
Comment 8 EWS 2021-03-26 13:37:15 PDT 
Committed r275111: <https://commits.webkit.org/r275111>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424366 [details].