Bug 223758

Summary:

[WebIDL] Remove [ImplicitThis] and [CustomProxyToJSObject] extended attributes

Product:

WebKit

Reporter:

Alexey Shvayka <ashvayka>

Component:

Bindings

Assignee:

Alexey Shvayka <ashvayka>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

alecflett, annulen, beidson, cdumez, clopez, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, jer.noble, joepeck, jsbell, keith_miller, kondapallykalyan, mark.lam, mkwst, msaboff, philipj, ryuan.choi, saam, sam, sergio, tzagallo, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=146785
https://github.com/web-platform-tests/wpt/pull/29027

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch for landing	ews-feeder: commit-queue-

Alexey Shvayka

Reported 2021-03-25 13:01:40 PDT Comment hidden (obsolete)

[WebIDL] Make |this| value casting consistent between IDLAttribute and IDLOperation

Attachments
Patch (139.92 KB, patch) 2021-03-25 13:08 PDT, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch (168.69 KB, patch) 2021-03-27 03:52 PDT, Alexey Shvayka	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (168.69 KB, patch) 2021-03-27 05:10 PDT, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch (80.59 KB, patch) 2021-05-11 00:32 PDT, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch (161.72 KB, patch) 2021-05-17 09:39 PDT, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch for landing (162.11 KB, patch) 2021-05-20 12:46 PDT, Alexey Shvayka	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Alexey Shvayka

Comment 1 2021-03-25 13:08:43 PDT Comment hidden (obsolete)

Created attachment 424272 [details] Patch

EWS Watchlist

Comment 2 2021-03-25 13:09:43 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Alexey Shvayka

Comment 3 2021-03-27 03:52:52 PDT Comment hidden (obsolete)

Created attachment 424445 [details] Patch Properly fix JSC not pass JSScope as |this| value (to be extracted before r?) and rebaseline LayoutTests/http/tests/security/listener tests.

Alexey Shvayka

Comment 4 2021-03-27 05:10:11 PDT Comment hidden (obsolete)

Created attachment 424448 [details] Patch Try to fix Windows build and correct wrong ASSERT in JSScope::resolve().

Radar WebKit Bug Importer

Comment 5 2021-04-01 13:03:17 PDT

<rdar://problem/76117359>

Alexey Shvayka

Comment 6 2021-05-11 00:32:59 PDT Comment hidden (obsolete)

Created attachment 428253 [details] Patch WIP

Alexey Shvayka

Comment 7 2021-05-17 09:39:04 PDT

Created attachment 428841 [details] Patch

Sam Weinig

Comment 8 2021-05-17 12:44:58 PDT

Comment on attachment 428841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428841&action=review > Source/WebCore/bindings/js/JSDOMCastThisValue.h:45 > +template<class JSClass> > +inline JSClass* castThisValue(JSC::JSGlobalObject& lexicalGlobalObject, JSC::JSValue thisValue) I think the inline is implicit and not needed in cases like this. > Source/WebCore/bindings/js/JSDOMGlobalObject.h:157 > +template<class JSClass> > +inline JSClass* toJSDOMGlobalObject(JSC::VM& vm, JSC::JSValue value) Same comment about inline.

Alexey Shvayka

Comment 9 2021-05-20 12:46:04 PDT

Created attachment 429207 [details] Patch for landing Remove extra 'inline' specifiers and sync now reviewed WPT from upstream.

Alexey Shvayka

Comment 10 2021-05-20 15:25:08 PDT

Committed r277830 (237976@main): <https://commits.webkit.org/237976@main>

Note You need to log in before you can comment on or make changes to this bug.