Bug 223758

Summary:

[WebIDL] Remove [ImplicitThis] and [CustomProxyToJSObject] extended attributes

Product:

WebKit

Reporter:

Alexey Shvayka <ashvayka>

Component:

Bindings

Assignee:

Alexey Shvayka <ashvayka>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

alecflett, annulen, beidson, cdumez, clopez, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, jer.noble, joepeck, jsbell, keith_miller, kondapallykalyan, mark.lam, mkwst, msaboff, philipj, ryuan.choi, saam, sam, sergio, tzagallo, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=146785
https://github.com/web-platform-tests/wpt/pull/29027

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch for landing	ews-feeder: commit-queue-

Description Alexey Shvayka 2021-03-25 13:01:40 PDT Comment hidden (obsolete)

[WebIDL] Make |this| value casting consistent between IDLAttribute and IDLOperation

Comment 1 Alexey Shvayka 2021-03-25 13:08:43 PDT Comment hidden (obsolete)

Created attachment 424272 [details]
Patch

Comment 2 EWS Watchlist 2021-03-25 13:09:43 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Comment 3 Alexey Shvayka 2021-03-27 03:52:52 PDT Comment hidden (obsolete)

Created attachment 424445 [details]
Patch

Properly fix JSC not pass JSScope as |this| value (to be extracted before r?) and rebaseline LayoutTests/http/tests/security/listener tests.

Comment 4 Alexey Shvayka 2021-03-27 05:10:11 PDT Comment hidden (obsolete)

Created attachment 424448 [details]
Patch

Try to fix Windows build and correct wrong ASSERT in JSScope::resolve().

Comment 5 Radar WebKit Bug Importer 2021-04-01 13:03:17 PDT

<rdar://problem/76117359>

Comment 6 Alexey Shvayka 2021-05-11 00:32:59 PDT Comment hidden (obsolete)

Created attachment 428253 [details]
Patch

WIP

Comment 7 Alexey Shvayka 2021-05-17 09:39:04 PDT

Created attachment 428841 [details]
Patch

Comment 8 Sam Weinig 2021-05-17 12:44:58 PDT

Comment on attachment 428841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428841&action=review

> Source/WebCore/bindings/js/JSDOMCastThisValue.h:45
> +template<class JSClass>
> +inline JSClass* castThisValue(JSC::JSGlobalObject& lexicalGlobalObject, JSC::JSValue thisValue)

I think the inline is implicit and not needed in cases like this.

> Source/WebCore/bindings/js/JSDOMGlobalObject.h:157
> +template<class JSClass>
> +inline JSClass* toJSDOMGlobalObject(JSC::VM& vm, JSC::JSValue value)

Same comment about inline.

Comment 9 Alexey Shvayka 2021-05-20 12:46:04 PDT

Created attachment 429207 [details]
Patch for landing

Remove extra 'inline' specifiers and sync now reviewed WPT from upstream.

Comment 10 Alexey Shvayka 2021-05-20 15:25:08 PDT

Committed r277830 (237976@main): <https://commits.webkit.org/237976@main>