Bug 223752

Summary: Some calls in AuthenticatorPresenterCoordinator::selectAssertionResponse are not yet available for mac
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Description Kate Cheney 2021-03-25 10:33:08 PDT 
Some calls in AuthenticatorPresenterCoordinator::selectAssertionResponse are not yet available for mac
Comment 1 Kate Cheney 2021-03-25 10:33:19 PDT 
Created attachment 424256 [details]
Patch
Comment 2 Kate Cheney 2021-03-25 10:33:22 PDT 
<rdar://problem/75808515>
Comment 3 Chris Dumez 2021-03-25 10:33:48 PDT 
Comment on attachment 424256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424256&action=review

> Source/WebKit/ChangeLog:3
> +        Need a short description (OOPS!).

OOPS
Comment 4 Kate Cheney 2021-03-25 10:38:16 PDT 
Created attachment 424257 [details]
Patch
Comment 5 Kate Cheney 2021-03-25 10:39:24 PDT 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 424256 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424256&action=review
> 
> > Source/WebKit/ChangeLog:3
> > +        Need a short description (OOPS!).
> 
> OOPS

!
Comment 6 Jiewen Tan 2021-03-25 11:02:38 PDT 
Comment on attachment 424257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424257&action=review

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43
> +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS)

I think it will be better to modify the conditions of enabling HAVE_ASC_AUTH_UI to include the PLATFORM(IOS).
Comment 7 Jiewen Tan 2021-03-25 11:03:52 PDT 
Comment on attachment 424257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424257&action=review

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43
>> +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS)
> 
> I think it will be better to modify the conditions of enabling HAVE_ASC_AUTH_UI to include the PLATFORM(IOS).

In PlatformHave.h. Thanks for fixing this issue.
Comment 8 Kate Cheney 2021-03-25 11:08:13 PDT 
Created attachment 424261 [details]
Patch
Comment 9 Kate Cheney 2021-03-25 11:08:33 PDT 
(In reply to Jiewen Tan from comment #6)
> Comment on attachment 424257 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424257&action=review
> 
> > Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43
> > +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS)
> 
> I think it will be better to modify the conditions of enabling
> HAVE_ASC_AUTH_UI to include the PLATFORM(IOS).

agreed! New patch posted.
Comment 10 Jiewen Tan 2021-03-25 11:25:37 PDT 
Comment on attachment 424261 [details]
Patch

LGTM. r=me.
Comment 11 EWS 2021-03-25 14:49:38 PDT 
Committed r275062: <https://commits.webkit.org/r275062>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424261 [details].