Bug 223748

Summary: Address some alignment issues found by UBSan in contentextensions code
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ggaren, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=176131
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Description Chris Dumez 2021-03-25 09:03:12 PDT 
Address some alignment issues found by UBSan in contentextensions code:
- contentextensions/SerializedNFA.h:55:20: runtime error: reference binding to misaligned address 0xnnnnnnnnn for type 'const unsigned long long', which requires 8 byte alignment
- contentextensions/NFAToDFA.cpp:254:29: runtime error: reference binding to misaligned address 0xnnnnnnnnn for type 'const unsigned long long', which requires 8 byte alignment
- contentextensions/DFABytecodeCompiler.cpp:43:5: runtime error: store to misaligned address 0xnnnnnnnnn for type 'unsigned short', which requires 2 byte alignment
Comment 1 Chris Dumez 2021-03-25 09:18:24 PDT 
Created attachment 424252 [details]
Patch
Comment 2 EWS 2021-03-25 11:28:37 PDT 
commit-queue failed to commit attachment 424252 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 3 EWS 2021-03-25 11:47:22 PDT 
Committed r275049: <https://commits.webkit.org/r275049>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424252 [details].
Comment 4 Radar WebKit Bug Importer 2021-03-25 11:48:16 PDT 
<rdar://problem/75846255>