Bug 223725

Summary:

WTF::setPermissionsOfConfigPage() should allow its VM_FLAGS_PERMANENT workaround unconditionally.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	saam: review+

Description Mark Lam 2021-03-24 19:45:18 PDT

If the OS does not support the flag, then we should not require it.

rdar://75813316

Comment 1 Mark Lam 2021-03-24 19:49:13 PDT

Created attachment 424211 [details]
proposed patch.

Comment 2 Saam Barati 2021-03-24 19:51:00 PDT

Comment on attachment 424211 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=424211&action=review

> Source/WTF/wtf/WTFConfig.cpp:81
>          // FIXME: Remove this when the oldest OS we support simulator on has VM_FLAGS_PERMANENT

Please remove this comment too

Comment 3 Mark Lam 2021-03-24 19:54:00 PDT

Thanks for the review.  Landed in r275003: <http://trac.webkit.org/r275003>.