RESOLVED FIXED Bug 223725
WTF::setPermissionsOfConfigPage() should allow its VM_FLAGS_PERMANENT workaround unconditionally.
https://bugs.webkit.org/show_bug.cgi?id=223725
Summary WTF::setPermissionsOfConfigPage() should allow its VM_FLAGS_PERMANENT workaro...
Mark Lam
Reported 2021-03-24 19:45:18 PDT
If the OS does not support the flag, then we should not require it. rdar://75813316
Attachments
proposed patch. (1.61 KB, patch)
2021-03-24 19:49 PDT, Mark Lam
saam: review+
Mark Lam
Comment 1 2021-03-24 19:49:13 PDT
Created attachment 424211 [details] proposed patch.
Saam Barati
Comment 2 2021-03-24 19:51:00 PDT
Comment on attachment 424211 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=424211&action=review > Source/WTF/wtf/WTFConfig.cpp:81 > // FIXME: Remove this when the oldest OS we support simulator on has VM_FLAGS_PERMANENT Please remove this comment too
Mark Lam
Comment 3 2021-03-24 19:54:00 PDT
Thanks for the review. Landed in r275003: <http://trac.webkit.org/r275003>.
Note You need to log in before you can comment on or make changes to this bug.