Bug 223725 - WTF::setPermissionsOfConfigPage() should allow its VM_FLAGS_PERMANENT workaround unconditionally.
Summary: WTF::setPermissionsOfConfigPage() should allow its VM_FLAGS_PERMANENT workaro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-24 19:45 PDT by Mark Lam
Modified: 2021-03-24 19:54 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch. (1.61 KB, patch)
2021-03-24 19:49 PDT, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-03-24 19:45:18 PDT
If the OS does not support the flag, then we should not require it.

rdar://75813316
Comment 1 Mark Lam 2021-03-24 19:49:13 PDT
Created attachment 424211 [details]
proposed patch.
Comment 2 Saam Barati 2021-03-24 19:51:00 PDT
Comment on attachment 424211 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=424211&action=review

> Source/WTF/wtf/WTFConfig.cpp:81
>          // FIXME: Remove this when the oldest OS we support simulator on has VM_FLAGS_PERMANENT

Please remove this comment too
Comment 3 Mark Lam 2021-03-24 19:54:00 PDT
Thanks for the review.  Landed in r275003: <http://trac.webkit.org/r275003>.