Bug 223714

Summary:

Use StaticStringImpl instead of StringImpl::createStaticStringImpl if it is not dynamic string content

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, darin, ews-watchlist, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	saam: review+

Description Yusuke Suzuki 2021-03-24 15:09:58 PDT

Use StaticStringImpl instead of StringImpl::createStaticStringImpl if it is not dynamic string content

Comment 1 Yusuke Suzuki 2021-03-24 15:11:30 PDT

Created attachment 424190 [details]
Patch

Comment 2 Yusuke Suzuki 2021-03-24 19:31:53 PDT

Committed r275002 (235740@main): <https://commits.webkit.org/235740@main>

Comment 3 Radar WebKit Bug Importer 2021-03-24 19:32:16 PDT

<rdar://problem/75818017>

Comment 4 Darin Adler 2021-03-25 16:23:48 PDT

Comment on attachment 424190 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424190&action=review

> Source/WTF/wtf/URL.cpp:858
> +static StaticStringImpl aboutBlankString { "about:blank" };

Why are these outside the functions?

> Source/WTF/wtf/URL.cpp:869
> +static StaticStringImpl aboutSrcDocString { "about:srcdoc" };

Ditto.