Bug 223698

Summary:

Web Inspector: REGRESSION (r269359): Timelines: TypeError: this.deselect is not a function

Product:

WebKit

Reporter:

Razvan Caliman <rcaliman>

Component:

Web Inspector

Assignee:

Razvan Caliman <rcaliman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar, Regression

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Razvan Caliman 2021-03-24 10:13:48 PDT

STR:

- Open WebInspector > Timelines
- Click the "Close" button for any of the sidebar items: Network Requests, Layout & Rendering, JavaScript & Events, CPU

Comment 1 Razvan Caliman 2021-03-24 10:14:39 PDT

Regressed by https://bugs.webkit.org/show_bug.cgi?id=196956

Comment 2 Radar WebKit Bug Importer 2021-03-24 10:16:04 PDT

<rdar://problem/75790983>

Comment 3 Razvan Caliman 2021-03-24 11:06:20 PDT

Error log:

```
TypeError: this.deselect is not a function. (In 'this.deselect()', 'this.deselect' is undefined) (at TimelineTreeElement.js:80:26)
    ? @ TimelineTreeElement.js:80:26
    dispatch @ Object.js:129:35
    dispatchEventToListeners @ Object.js:137:17
    _clicked @ TreeElementStatusButton.js:78:38
    _clicked @ [native code]
```

Comment 4 Razvan Caliman 2021-03-24 11:07:01 PDT

Created attachment 424160 [details]
Patch

Comment 5 BJ Burg 2021-03-24 11:44:46 PDT

Comment on attachment 424160 [details]
Patch

r=me

Comment 6 EWS 2021-03-24 12:31:26 PDT

Committed r274960: <https://commits.webkit.org/r274960>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424160 [details].