Bug 223678

Summary: [JSC] Rope string equal operation should first check length
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mark.lam: review+, ews-feeder: commit-queue-
Patch none

Description Yusuke Suzuki 2021-03-24 00:52:39 PDT 
[JSC] Rope string equal operation should first check length
Comment 1 Yusuke Suzuki 2021-03-24 00:53:20 PDT 
Created attachment 424102 [details]
Patch
Comment 2 Mark Lam 2021-03-24 01:04:37 PDT 
Comment on attachment 424102 [details]
Patch

r=me.  I’m surprised we aren’t already doing this.
Comment 3 Ryosuke Niwa 2021-03-24 01:09:43 PDT 
Comment on attachment 424102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424102&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        This can avoid eagerly resolving rope strings if it is not necessary.

lol, this is hilarious!
Comment 4 Yusuke Suzuki 2021-03-24 01:19:07 PDT 
stress/redefine-property-same-value-exception-check.js is failing, just because this relies on the fact that this function resolves rope string (and throwing OOM error). We should fix the test.
Comment 5 Yusuke Suzuki 2021-03-24 01:35:27 PDT 
Created attachment 424105 [details]
Patch
Comment 6 Yusuke Suzuki 2021-03-24 02:54:40 PDT 
Failed stress/redefine-property-same-value-exception-check.js test is fixed, and ensured in jsc-armv7-tests result.
Comment 7 Yusuke Suzuki 2021-03-24 02:56:22 PDT 
Committed r274935 (235693@main): <https://commits.webkit.org/235693@main>
Comment 8 Radar WebKit Bug Importer 2021-03-24 02:57:13 PDT 
<rdar://problem/75777656>