Bug 223652

Summary:

Add IOKit method filter telemetry

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

223811, 224048, 224094

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Per Arne Vollan

Reported 2021-03-23 13:07:49 PDT

Add IOKit method filter telemetry in the WebContent sandbox on macOS and iOS.

Attachments
Patch (6.70 KB, patch) 2021-03-23 13:15 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (8.20 KB, patch) 2021-03-30 14:38 PDT, Per Arne Vollan	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (9.98 KB, patch) 2021-03-31 06:36 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (10.31 KB, patch) 2021-03-31 06:42 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (11.22 KB, patch) 2021-03-31 07:15 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (11.22 KB, patch) 2021-03-31 07:24 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (11.46 KB, patch) 2021-03-31 09:33 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (13.28 KB, patch) 2021-03-31 12:44 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (13.29 KB, patch) 2021-04-01 09:34 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (14.51 KB, patch) 2021-04-02 07:38 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-03-23 13:08:09 PDT

<rdar://problem/75751391>

Per Arne Vollan

Comment 2 2021-03-23 13:15:24 PDT

Created attachment 424055 [details] Patch

Alex Christensen

Comment 3 2021-03-23 13:35:32 PDT

Comment on attachment 424055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424055&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:358 > + 0 Is this a functional change?

Brent Fulgham

Comment 4 2021-03-23 16:24:23 PDT

Comment on attachment 424055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424055&action=review r=me >> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:358 >> + 0 > > Is this a functional change? Not really -- it just means we are allowing these methods, and collecting telemetry on the others. As opposed to collecting telemetry on all of them.

Per Arne Vollan

Comment 5 2021-03-24 06:59:46 PDT

Comment on attachment 424055 [details] Patch Thanks for reviewing!

EWS

Comment 6 2021-03-24 07:28:29 PDT

Committed r274938: <https://commits.webkit.org/r274938> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424055 [details].

WebKit Commit Bot

Comment 7 2021-03-26 12:15:14 PDT

Re-opened since this is blocked by bug 223811

Per Arne Vollan

Comment 8 2021-03-30 14:38:26 PDT

Created attachment 424700 [details] Patch