Bug 223619

Summary: [WinCairo] Implement inspector-resource:// URL scheme handler for Web Inspector resources
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebKit2Assignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bburg, don.olmstead, ews-watchlist, gyuyoung.kim, hi, joepeck, kkinnunen, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 223566    
Attachments:
Description Flags
Patch
none
Patch none

Fujii Hironori
Reported 2021-03-22 18:41:43 PDT
[WinCairo] Implement inspector-resource:// URL scheme handler for Web Inspector resources See also: Bug 179904 – [Cocoa] Web Inspector: load inspector resources using a custom scheme handler
Attachments
Patch (11.18 KB, patch)
2021-03-22 18:48 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (11.22 KB, patch)
2021-03-22 19:00 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-03-22 18:48:38 PDT
Created attachment 423977 [details] Patch
Fujii Hironori
Comment 2 2021-03-22 19:00:54 PDT
Created attachment 423978 [details] Patch
Don Olmstead
Comment 3 2021-03-23 08:31:40 PDT
Comment on attachment 423978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423978&action=review Isn't this going to break inspector on AppleWin? > Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:47 > + auto path = URL(adoptCF(CFBundleCopyBundleURL(WebCore::webKitBundle())).get()).fileSystemPath(); This is the only CF related code. > Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:53 > + task.didComplete(WebCore::ResourceError::httpError(CURLE_READ_ERROR, requestURL)); This is the only CURL related code.
Fujii Hironori
Comment 4 2021-03-23 12:25:46 PDT
Comment on attachment 423978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423978&action=review >> Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:47 >> + auto path = URL(adoptCF(CFBundleCopyBundleURL(WebCore::webKitBundle())).get()).fileSystemPath(); > > This is the only CF related code. Yes. It's enclosed #if by USE(CF) && USE(CURL). >> Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:53 >> + task.didComplete(WebCore::ResourceError::httpError(CURLE_READ_ERROR, requestURL)); > > This is the only CURL related code. Yes. It's enclosed #if by USE(CF) && USE(CURL).
Fujii Hironori
Comment 5 2021-03-23 12:26:30 PDT
(In reply to Don Olmstead from comment #3) > Isn't this going to break inspector on AppleWin? I don't think so. I didn't change WebKit1.
Fujii Hironori
Comment 6 2021-03-23 17:15:28 PDT
Comment on attachment 423978 [details] Patch Clearing flags on attachment: 423978 Committed r274912 (235682@main): <https://commits.webkit.org/235682@main>
Fujii Hironori
Comment 7 2021-03-23 17:15:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2021-03-23 17:16:14 PDT
<rdar://problem/75762697>
Fujii Hironori
Comment 9 2021-03-23 17:19:05 PDT
*** Bug 223566 has been marked as a duplicate of this bug. ***
Blaze Burg
Comment 10 2021-03-25 11:43:39 PDT
Thanks for adding this!
Note You need to log in before you can comment on or make changes to this bug.