| Summary: | [webkitscmpy] Base GitHub mock links on provided remote | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, dewei_zhu, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=221860 | ||||||
| Attachments: |
|
||||||
|
Description
Jonathan Bedard
2021-03-22 16:16:40 PDT
Created attachment 423958 [details]
Patch
Comment on attachment 423958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423958&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:211 > + ' <include-fragment src="/{project}/tree-commit/{ref}" aria-label="Loading latest commit">\n' now that project contains complete url (starting from github.example.com), should the src still start with /? Comment on attachment 423958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423958&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:211 >> + ' <include-fragment src="/{project}/tree-commit/{ref}" aria-label="Loading latest commit">\n' > > now that project contains complete url (starting from github.example.com), should the src still start with /? That's why line 229 does "self.remote.split('/')[1:]", we don't want the github.example.com bit, just the team name/repository name Committed r274830: <https://commits.webkit.org/r274830> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423958 [details]. |