Bug 223611 – [webkitscmpy] Base GitHub mock links on provided remote

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

Mock links in GitHub responses should be based on the remote provided.

[Radar WebKit Bug Importer]

<rdar://problem/75713760>

[Jonathan Bedard]

Created attachment 423958 [details]
Patch

[Aakash Jain]

Comment on attachment 423958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423958&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:211
> +            '            <include-fragment src="/{project}/tree-commit/{ref}" aria-label="Loading latest commit">\n'

now that project contains complete url (starting from github.example.com), should the src still start with /?

[Jonathan Bedard]

Comment on attachment 423958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423958&action=review

>> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:211
>> +            '            <include-fragment src="/{project}/tree-commit/{ref}" aria-label="Loading latest commit">\n'
> 
> now that project contains complete url (starting from github.example.com), should the src still start with /?

That's why line 229 does "self.remote.split('/')[1:]", we don't want the github.example.com bit, just the team name/repository name

[EWS]

Committed r274830: <https://commits.webkit.org/r274830>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423958 [details].