Bug 223605

Summary: dom/WheelEvent.cpp:47:58: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, ggaren, kangil.han, sam, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=176131
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-03-22 15:06:13 PDT
Update WheelEvent constructor to deal with overflow when negating wheelDelta values, instead of having undefined behavior.
Attachments
Patch (2.54 KB, patch)
2021-03-22 15:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.76 KB, patch)
2021-03-22 16:13 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.16 KB, patch)
2021-03-22 19:48 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-03-22 15:07:57 PDT
Created attachment 423944 [details] Patch
Chris Dumez
Comment 2 2021-03-22 16:13:53 PDT
Created attachment 423955 [details] Patch
Chris Dumez
Comment 3 2021-03-22 19:48:01 PDT
Created attachment 423982 [details] Patch
EWS
Comment 4 2021-03-23 09:46:19 PDT
Committed r274876: <https://commits.webkit.org/r274876> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423982 [details].
Radar WebKit Bug Importer
Comment 5 2021-03-23 09:47:15 PDT
<rdar://problem/75741712>
Note You need to log in before you can comment on or make changes to this bug.