Bug 223605

Summary: dom/WheelEvent.cpp:47:58: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, ggaren, kangil.han, sam, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=176131
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2021-03-22 15:06:13 PDT
Update WheelEvent constructor to deal with overflow when negating wheelDelta values, instead of having undefined behavior.
Comment 1 Chris Dumez 2021-03-22 15:07:57 PDT
Created attachment 423944 [details]
Patch
Comment 2 Chris Dumez 2021-03-22 16:13:53 PDT
Created attachment 423955 [details]
Patch
Comment 3 Chris Dumez 2021-03-22 19:48:01 PDT
Created attachment 423982 [details]
Patch
Comment 4 EWS 2021-03-23 09:46:19 PDT
Committed r274876: <https://commits.webkit.org/r274876>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423982 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-23 09:47:15 PDT
<rdar://problem/75741712>